On 9/11/2015 4:00 PM, Michael H Lambert wrote: >> On 11 Sep 2015, at 15:37, Lou Berger <[email protected]> wrote: >> >> This is inconsistent with the current afi/safi config: >> >> address-family vpnv4 >> neighbor 127.0.0.115 activate >> neighbor 127.0.0.115 route-reflector-client >> neighbor 127.0.0.116 activate >> neighbor 127.0.0.116 route-reflector-client >> exit-address-family >> ! > Oh dear. Am I correct that vpnv4 is a shorthand for afi==1, safi==4? I'm > guessing it's too late to replace "address-family vpnv4" with "address-family > ipv4 vpn" or the like.
I have to say I think this is an area that can stand some improvement. On top of what's there we've added VPN SAFI for V6 and ENCAP SAFI for v4 and v6. (and am planning on adding EVPN SAFI in the near future.) -- This was discussed a while back (https://lists.quagga.net/pipermail/quagga-dev/2014-March/011189.html). We followed existing approach of 'address-family ipv4' and have added address-family vpnv6 address-family encapv4 address-family encapv6 We tried to make things sane on the 'show' side namely: show bgp (ipv4|ipv6) (encap|multicast|unicast|vpn) I think changing the config convention to address-family to address-family <afi> <safi> would be a good change. of course this doesn't alter the original discussion... BTW the core SAFI code, without the more interesting import/export code, has been merged with the latest code and is at https://github.com/LabNConsulting/quagga-vnc > Michael > > > _______________________________________________ > Quagga-dev mailing list > [email protected] > https://lists.quagga.net/mailman/listinfo/quagga-dev > _______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
