My only take on it, is that I do not like dead code just commented out. It ends up clogging up the code for no value. Especially since decode_label() does nothing.
On the other hand, it's a stupidly easy fix. If it'll make your life easier I can make the change for Denil. donald On Wed, Sep 16, 2015 at 12:22 PM, Paul Jakma <[email protected]> wrote: > I'd kind of be minded to just comment that line, but leave it to document > that that is possible there. Unless you or others have strong feelings > about that, could you resend in that form? > > regards, > > Paul > > On Thu, 23 Jul 2015, Denil Vira wrote: > > Coverity scan ID : 1302528. Calling "decode_label(pnt)" is only useful for >> its return value, which is >> ignored. Removed the call. >> >> Signed-off-by: Denil Vira <[email protected]> >> --- >> bgpd/bgp_mplsvpn.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/bgpd/bgp_mplsvpn.c b/bgpd/bgp_mplsvpn.c >> index 3d2dade..cf4ab6f 100644 >> --- a/bgpd/bgp_mplsvpn.c >> +++ b/bgpd/bgp_mplsvpn.c >> @@ -116,9 +116,6 @@ bgp_nlri_parse_vpnv4 (struct peer *peer, struct attr >> *attr, >> zlog_err ("prefix length is less than 88: %d", prefixlen); >> return -1; >> } >> - >> - /* XXX: Not doing anything with the label */ >> - decode_label (pnt); >> >> /* Copyr label to prefix. */ >> tagpnt = pnt;; >> >> > -- > Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A > Fortune: > "The dead should not care about proper locking, > those are realms of the living..." > > - Tigran Aivazian > > > _______________________________________________ > Quagga-dev mailing list > [email protected] > https://lists.quagga.net/mailman/listinfo/quagga-dev >
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
