On 21 Sep 2015, at 2:50, Paul Jakma wrote:

On Fri, 18 Sep 2015, Olivier Dugeon wrote:

Hello Paul,

Some of my colleague who are working for OpenStack told me that GitReview is a very great system. It allows smooth code review and work with great amount of contributors. Yeah, Quagga has not yet reach the same numbers of developers as OpenStack :-D

I don't know which amount of work this change would imply, but I just would share some experience with you about this tools.

I've just recently been looking at some projects that use Gerrit, and it seems good. Though, it pretty much takes over, IUIC.

No tool is perfect, but maybe some kind of tool is better than a very ad-hoc and labour intensive one..

If the major work you try to solve is tracking changes to submitted patches, then this might work. From the CI system integration, anything which somehow can automatically trigger a CI on changes/submissions
etc and (preferably) receive result reports back somehow works for me.


Concerns about gerrit (feel free to correct/extend)

1) gerrit would replace patchwork, savannah and some of the quagga-dev mailing list (discussion of the patches). How much extra server maintenance etc is added in exchange of making it easier to follow patches? Does
it just take some work away and replace it with other work?

2) I somehow worry if this makes it even harder for new contributors to figure out how to get involved.

3) The discussion (which I started) was not about replacing patchwork or code review, but mainly about the bundling of multiple patches at the same time. This is not an argument against any of these tools, but I’m missing the point why reviewed/approved patches can’t go into git immediately. What is the advantage to bundle something like 10 patches together, review them together and push them
together as done in the last 2 rounds by Paul?

4) Wow.. gerrit uses Prolog! I have distant memories working with Borlang Turbo-Prolog. Never expected
that Prolog is still around…

5) Curious on other choices and their pros/cons…


Regards,
   Martin Winter

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to