On Wed, 23 Sep 2015, Martin Winter wrote:
Spent some time testing all (at least the ones in patchwork) of these
patches. Please don’t take a PASS below as an ACK - it only means that
it passed my basic CI system tests (haven’t run the full ones - Limited
it to 1hr runtime for a “quick” test)
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/3/proposed/ff
Not sure if these is a Git Newbie question. I find all the commits in
Savannah under this URL, but I can’t check out any of them. All
complaining to commit not found and I can’t checkout the branch either.
Do I miss something stupid here or is this some hidden/protected branch?
Hmm, what happens?
At worst, you should definitely be able to checkout the commit ID, e.g.:
$ git checkout 86a34b7b866737b3f574f79e5e2426c4c800f45d
—-Werror-enable fails on these platforms:
CentOS 6 (see
https://ci1.netdef.org/browse/TESTING-WERROR-CI006BUILD-1 )
cc1: error: unrecognized command line option
"-Wno-unused-result"
NetBSD 6 (see
https://ci1.netdef.org/browse/TESTING-WERROR-CI007BUILD-1 )
pim_cmd.c: In function 'show_mroute_count':
pim_cmd.c:2353:10: error: format '%d' expects type 'int', but
argument 3 has type 'long unsigned int'
Urg. Does the attached fix it?
FAILS. Patch fails to apply on current master.
That will be the case for a few of them. You'll need to get the git commit
in the proposed tree for this round.
zebra/rt_netlink.c which fails to apply. But even with this changed,
please see above. We need to fix the warnings for the other OS first
before pushing this change. I would prefer to delay this one for the
next round to give enough time to clean up the warnings.
Ok.
Not tested with CI. (I’m currently ignoring the SPEC file and use my
own) However, would prefer to get more time on this. It kind of
conflicts with the other patch (the one I submitted with
pimd.init/service files) as it doesn’t start pimd and doesn’t install
these files. A quick look at it also gives me the impression that it
won’t work on CentOS 7 / RedHat 7 as it uses the old init files for
startup instead of the services files.
I think both are in there? The pimd too?
And yes, need to sync up further for systemd, and figure out if we can
support both pre-systemd CentOS 6 and post.
regards,
--
Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A
Fortune:
A lie is an abomination unto the Lord and a very present help in time of
trouble.
-- Adlai Stevensondiff --git a/pimd/pim_cmd.c b/pimd/pim_cmd.c
index 55545c1..286af73 100644
--- a/pimd/pim_cmd.c
+++ b/pimd/pim_cmd.c
@@ -2344,8 +2344,11 @@ static void show_mroute_count(struct vty *vty)
if (ioctl(qpim_mroute_socket_fd, SIOCGETSGCNT, &sgreq)) {
int e = errno;
vty_out(vty,
- "ioctl(SIOCGETSGCNT=%d) failure for (S,G)=(%s,%s): errno=%d: %s%s",
- SIOCGETSGCNT,
+ "ioctl(SIOCGETSGCNT=%lu) failure for (S,G)=(%s,%s): errno=%d: %s%s",
+ /* note that typeof ioctl defs can vary across platforms, from
+ * int, to unsigned int, to long unsigned int
+ */
+ (long unsigned int)SIOCGETSGCNT,
source_str,
group_str,
e,
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
