Patches respun and I'd like to retract any comments on the style. I'm not
sure that I really want to get into a discussion about it.
thanks!
donald
On Thu, Sep 24, 2015 at 7:18 AM, Donald Sharp <sha...@cumulusnetworks.com>
wrote:
> I find Quagga's coding style pretty awful.
>
> I prefer having a space in a function name only after the definition and
> any usage of the function without a space. This way I can just easily
> search for the function name with a space following it to find it.
>
> In any event, I'll respin the change here in a bit.
>
> donald
>
> On Thu, Sep 24, 2015 at 5:50 AM, Paul Jakma <p...@jakma.org> wrote:
>
>> On Wed, 23 Sep 2015, Donald Sharp wrote:
>>
>> zclient.c depended upon link time inclusion of a
>>> extern struct thread_master *master. This is a violation of the
>>> namespace of the calling daemon. If a library needs the pointer
>>> pass it in and save it for future use.
>>>
>>> This code change also makes the zclient code consistent with
>>> the other lib functions that need to schedule work on your behalf
>>>
>>
>> Ack.
>>
>> One little style issue:
>>
>> @@ -1434,7 +1434,7 @@ bgp_config_write_scan_time (struct vty *vty)
>>> void
>>> bgp_scan_init (void)
>>> {
>>> - zlookup = zclient_new ();
>>> + zlookup = zclient_new(master);
>>>
>>
>> Quagga uses (mostly) the GNU style of having a space between functions
>> and the arg list. I even find it helps readability a bit (maybe just cause
>> I've gotten used to it, I'll admit).
>>
>> Just for consistency, can you editdiff and add the spaces back? :)
>>
>> regards,
>> --
>> Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A
>> Fortune:
>> The meek shall inherit the earth, but *not* its mineral rights.
>> -- J.P. Getty
>>
>
>
_______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev
