Hi Amritha,
Thanks very much for that. Just one little thing, with Werror on (which
we're trying ot make the default), it bombs out on a signed/unsigned
comparison in 2 places:
On Tue, 13 Oct 2015, Amritha Nambiar wrote:
@@ -230,12 +230,24 @@ isis_recv_pdu_bcast (struct isis_circuit *circuit, u_char
* ssnpa)
+ if (s_addr.sll_ifindex != circuit->interface->ifindex)
On this and similar one before I get:
isis_pfpacket.c: In function ‘isis_recv_pdu_bcast’:
isis_pfpacket.c:233:46: error: comparison between signed and unsigned
integer expressions [-Werror=sign-compare]
if ((bytesread < 0) || (s_addr.sll_ifindex != circuit->interface->ifindex))
^
isis_pfpacket.c:242:30: error: comparison between signed and unsigned
integer expressions [-Werror=sign-compare]
if (s_addr.sll_ifindex != circuit->interface->ifindex)
Could you supply an additional commit to fix that, so that I could apply
before this patch?
regards,
--
Paul Jakma [email protected] @pjakma Key ID: 64A2FF6A
Fortune:
"The geeks shall inherit the earth."
-- Karl Lehenbauer
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
