In bgp, I've noticed this series of events a few times:

(A) Build the source code.
(B) Modify a .h file, say bgp_fsm.h:
sharpd@Robot-1:~/q2/bgpd$ git diff
diff --git a/bgpd/bgp_fsm.h b/bgpd/bgp_fsm.h
index a749f8e..35345a4 100644
--- a/bgpd/bgp_fsm.h
+++ b/bgpd/bgp_fsm.h
@@ -26,7 +26,7 @@ Software Foundation, Inc., 59 Temple Place - Suite 330,
Boston
 #define BGP_READ_ON(T,F,V)                     \
   do {                                         \
     if (!(T) && (peer->status != Deleted))     \
-      THREAD_READ_ON(master,T,F,peer,V);       \
+      THREAD_READ_ON(bm->master,T,F,peer,V);   \
   } while (0)

 #define BGP_READ_OFF(T)                                \


(C) Rebuild:
sharpd@Robot-1:~/q2/bgpd$ make
make: Nothing to be done for `all'.
sharpd@Robot-1:~/q2/bgpd$

If I manually remove bgp_fsm.o( which calls the BGP_READ_ON ) and recompile
we can see that the .o file sizes change:
sharpd@Robot-1:~/q2/bgpd$ ls -l bgp_fsm.o
-rw-rw-r-- 1 sharpd sharpd 90296 Oct 13 19:06 bgp_fsm.o
sharpd@Robot-1:~/q2/bgpd$ rm bgp_fsm.o
sharpd@Robot-1:~/q3/bgpd$ make
  CC       bgp_fsm.o
  AR       libbgp.a
  CCLD     bgpd
sharpd@Robot-1:~/q3/bgpd$ ls -l bgp_fsm.o
-rw-rw-r-- 1 sharpd sharpd 90784 Oct 13 19:19 bgp_fsm.o

I've done some very preliminary poking at the configure.ac and
bgpd/Makefile.am and don't immediately see a fix for the issue.  I was
hoping someone has some experience in this world that could take a look and
point me in the right direction on how to fix it.  The documentation that
I've read this evening points to the fact that 'it should just work'.  It
sure would be nice to have an actual correct recompile if you change a
header file as that it's introduced false bugs that we've had to track down
and fix.

donald
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to