On 11/10/2015 05:54 PM, Paul Jakma wrote:
> On Tue, 10 Nov 2015, Christian Franke wrote:
>
>> These issues have been found by running buildtest.sh
>> using GCC 5.2.0 and Clang 3.7.0
>
>
>> else
>> - adj_name = adj->sysid ? sysid_print (adj->sysid) : "unknown";
>> + adj_name = sysid_print (adj->sysid);
>
> Why does that warn?
>
>> if (IS_RIP_DEBUG_EVENT)
>> zlog_debug("SEND UPDATE to %s ifindex %d",
>> - (ifp->name ? ifp->name : "_unknown_"), ifp->ifindex);
>> + ifp->name, ifp->ifindex);
Because ifp->name is of type char[IFNAMSIZ] so it will never be NULL.
adj->sysid is also an array. The compiler recognizes this and warns
about a check that will always be true.
-Christian
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
