Acked-by: Donald Sharp <[email protected]>

On Tue, Nov 10, 2015 at 1:34 PM, Christian Franke <
[email protected]> wrote:

> On 11/10/2015 07:11 PM, Donald Sharp wrote:
> > Shouldn't these warn's be debugs protected by guards?
>
> I am not sure what the agreed-upon policy on log messages is.
>
> These codepaths are normally not taken, if it happens, it is a bug. I
> just did not want to put an assert there since there is no real need to
> abort isisd. So my reasoning was that it is a very exceptional case when
> this path is taken and it should always show up in the logs regardless
> of any guards.
>
> This patch also fixes the only bug that I know which causes the
> condition that triggers these messages. (And would crash isisd before
> this patch)
>
> -Christian
>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to