Sorry Donald, I don't even have a quagga master setup here, much less anything
to run it on and even less time to work on it.
When/if I get to quagga master I will resubmit missing parts.
I don't mind if you(or anyone else) just scoops these patches into your own,
they are just small bug fixes.
Jocke
On Tue, 2015-11-10 at 15:40 -0500, Donald Sharp wrote:
Joakim -
If you resubmit your patch, I'll ACK it and work towards getting the code in(
and obviously remove the Patch from Vipin from our proposed tree ). I would
hate to see your good work sitting idly by the side due to past issues.
donald
On Tue, Nov 10, 2015 at 3:13 PM, Joakim Tjernlund
<[email protected]<mailto:[email protected]>> wrote:
No, I am way behind quagga master and having submitted so much stuff that never
went anywere.
Now I can only point at my old stuff and hope someone picks it it up.
I hope Quagga soon has what I need and then I will consider upgrading.
It is not the same fix, it is more of the same and also includes VLINKs.
Jocke
On Tue, 2015-11-10 at 14:59 -0500, Donald Sharp wrote:
Joakim -
Are you planning on fixing up your two submissions and resubmitting?
donald
On Tue, Nov 10, 2015 at 2:46 PM, Donald Sharp
<[email protected]<mailto:[email protected]>> wrote:
Yep looks like the same fix.
donald
On Tue, Nov 10, 2015 at 11:49 AM, Joakim Tjernlund
<[email protected]<mailto:[email protected]>> wrote:
On Tue, 2015-11-10 at 09:33 -0500, Donald Sharp wrote:
> From: Vipin Kumar
> <[email protected]<mailto:[email protected]>>
>
> ISSUE:
>
> LSAcks (for directed acks) are being sent to neighbor's unicast address.
>
> RFC 2328 says:
>
> "The IP destination address for the packet is selected as
> follows. On physical point-to-point networks, the IP
> destination is always set to the address AllSPFRouters"
>
> Fix is to unconditionally set the destination address for LSAcks over
> point-to-point links as AllSPFRouters. Quagga OSPF already has similar
> change for OSPF DBD, LSUpdate and LSrequest packets.
Yes, but I think it is incomplete. Have a look at my old patch(es) at:
http://patchwork.quagga.net/patch/30/
http://patchwork.quagga.net/patch/32/
and tell me what you think.
These 2 patches really started with
http://patchwork.quagga.net/patch/6/
but bindtodevice was not really needed as I recall.
Jocke
>
> Signed-off-by: Vipin Kumar
> <[email protected]<mailto:[email protected]>>
> Reviewed-by: Daniel Walton
> <[email protected]<mailto:[email protected]>>
> Reviewed-by: Dinesh G Dutt
> <[email protected]<mailto:[email protected]>>
> ---
> ospfd/ospf_packet.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/ospfd/ospf_packet.c b/ospfd/ospf_packet.c
> index ea76ab8..65b15fc 100644
> --- a/ospfd/ospf_packet.c
> +++ b/ospfd/ospf_packet.c
> @@ -3854,9 +3854,12 @@ ospf_ls_ack_send_list (struct ospf_interface *oi,
> struct list *ack,
> /* Set packet length. */
> op->length = length;
>
> - /* Set destination IP address. */
> - op->dst = dst;
> -
> + /* Decide destination address. */
> + if (oi->type == OSPF_IFTYPE_POINTOPOINT)
> + op->dst.s_addr = htonl (OSPF_ALLSPFROUTERS);
> + else
> + op->dst.s_addr = dst.s_addr;
> +
> /* Add packet to the interface output queue. */
> ospf_packet_add (oi, op);
>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
