Michael -

That is not part of this patch and if you feel as if BGP_PRIVATE_AS_MAX is
in error, please feel free to submit a patch to fix the issue as
appropriate.

thanks!

donald

On Fri, Nov 13, 2015 at 2:52 PM, Michael H Lambert <[email protected]> wrote:

> I'm not sure I'd noticed this before, but, based on
> http://www.iana.org/assignments/iana-as-numbers-special-registry/iana-as-numbers-special-registry.xhtml,
> shouldn't we have
>
> #define BGP_PRIVATE_AS_MAX      65534U
>
> ASN 65535 is reserved, not private.
>
> Michael
>
> > On 13 Nov 2015, at 14:19, Donald Sharp <[email protected]>
> wrote:
> >
> > diff --git a/bgpd/bgp_aspath.h b/bgpd/bgp_aspath.h
> > index 1311f8a..15b09f5 100644
> > --- a/bgpd/bgp_aspath.h
> > +++ b/bgpd/bgp_aspath.h
> > @@ -31,6 +31,10 @@ Software Foundation, Inc., 59 Temple Place - Suite
> 330, Boston, MA
> > #define BGP_PRIVATE_AS_MIN       64512U
> > #define BGP_PRIVATE_AS_MAX       65535U
> >
> > +/* Private 4 byte AS range defined in RFC6996.  */
> > +#define BGP_PRIVATE_AS4_MIN     4200000000U
> > +#define BGP_PRIVATE_AS4_MAX     4294967294U
> > +
> > /* we leave BGP_AS_MAX as the 16bit AS MAX number.  */
> > #define BGP_AS_MAX                 65535U
> > #define BGP_AS4_MAX           4294967295U
> > --
>
>
> _______________________________________________
> Quagga-dev mailing list
> [email protected]
> https://lists.quagga.net/mailman/listinfo/quagga-dev
>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to