Donald,

On 12 Dec 2015, at 4:15, Donald Sharp wrote:

Totally pushed it:

https://github.com/donaldsharp/quagga/commit/67b07279bf38db853aab1265bf61fdcb9dfcda4e

donald

Doesn’t seem to fix the crash. I still see the failures:
https://ci1.netdef.org/browse/QUAGGA-CUMULUS-22#existing-failed-tests

Let me know if you need additional debugging (bisects or others) to locate the problem

Regards,

- Martin Winter

On Sat, Dec 12, 2015 at 1:14 AM, Martin Winter <
[email protected]> wrote:

Thanks,

I don’t see this pushed (yet). Did you forget to push?
Will verify after it’s on the git.

- Martin


On 11 Dec 2015, at 19:40, Donald Sharp wrote:

Martin -

Thanks for finding this.

Fixed in commit 67b07279bf38db853aab1265bf61fdcb9dfcda4e

donald

On Fri, Dec 11, 2015 at 8:58 PM, Martin Winter <
[email protected]> wrote:

Still crashes OSPFv2 with simple configuration of OSPF. See below.
Let me know if you need more help to reproduce or locating the issue.

All my OSPFv2 tests fail. Other protocols work for basic tests.

- Martin


dut# sh run

Building configuration...

Current configuration:

[…]

password zebra
enable password zebra
!

[…]

interface eth2
ip address 192.168.1.101/24
link-detect
!

[…]

dut# conf t
dut(config)# router ospf
dut(config-router)#  network 192.168.1.0/24  area 0.0.0.0


—> crash

*** Error in `/usr/local/sbin/ospfd': double free or corruption
(fasttop):
0x0000000000691560 ***

Program received signal SIGABRT, Aborted.
0x00007ffff7523cc9 in __GI_raise (sig=sig@entry=6)
at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56      ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or
directory.

Program received signal SIGABRT, Aborted.
0x00007ffff7523cc9 in __GI_raise (sig=sig@entry=6)
at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56      ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or
directory.
(gdb)

(gdb) bt
#0  0x00007ffff7523cc9 in __GI_raise (sig=sig@entry=6)
at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x00007ffff75270d8 in __GI_abort () at abort.c:89
#2 0x00007ffff7560394 in __libc_message (do_abort=do_abort@entry=1,
fmt=fmt@entry=0x7ffff766eb28 "*** Error in `%s': %s: 0x%s ***\n")
at ../sysdeps/posix/libc_fatal.c:175
#3  0x00007ffff756c66e in malloc_printerr (ptr=<optimized out>,
str=0x7ffff766ecf0 "double free or corruption (fasttop)", action=1) at
malloc.c:4996
#4 _int_free (av=<optimized out>, p=<optimized out>, have_lock=0) at
malloc.c:3840
#5 0x00007ffff78e156b in zfree (type=6, ptr=0x691560) at memory.c:132 #6 0x00007ffff78caa9e in listnode_free (node=0x691560) at linklist.c:52 #7 0x00007ffff78cb20d in list_delete_node (list=0x68fc00, node=0x691560)
at linklist.c:266
#8  0x00007ffff7b61ea8 in ospf_write (thread=0x7fffffffe560) at
ospf_packet.c:815
#9  0x00007ffff78dea39 in thread_call (thread=0x7fffffffe560) at
thread.c:1266
#10 0x00000000004019eb in main (argc=1, argv=0x7fffffffe6c8) at
ospf_main.c:341






On 11 Dec 2015, at 15:50, Donald Sharp wrote:

Updated to latest version of master.

Addressed Paul's Comments about headers.
Another round of OSPF unnumbered.

Ayan Banerjee (5):
zebra: ipv6 multipath support
bgpd: Enable support for BGP IPV6 multipath.
ospfd: Ensure deletion is clean
ospfd: Ensure that OSPF can send out multiple packets per thread
ospfd: Limit the number of interfaces serviced at one time

Daniel Walton (31):
bgpd: don't count a route with an unreachable nexthop in PfxRcd
bgpd: Improve peer scaling
ospf6d, ripd, vtysh: Fix "no set metric" for ospf6 and RIP
bgpd: Make "no redistribute" always remove the redistribute statement bgpd: iBGP multipath is broken if 'bgp deterministic-med' is enabled.
bgpd: Fix aggregation issues found via ANVL
bgpd: Add clear command to force a bestpath recalculation and
re-advertisement of a prefix
bgpd: crash if attributes alone consume > 4096 bytes
bgpd: Add [bestpath|multipath] option to 'show ip bgp x.x.x.x'
ospf6d: We should accept long form of "no redistribute"
bgpd: Display BGP paths with unreachable nexthps as invalid
ospfd: Fix no ip ospf hello-interval
ospfd: "show ip ospf neighbor" header spacing
bgpd: flag paths for multipath if we RX link-local and global nexthops
zebra: Add internal support for route tags
bgpd, lib, ospfd, zebra: Add ability to read/write tag value
bgpd, vtysh: Add support for route tags
ospfd, vtysh: Add support for Route tags
ripd, ripngd: add support for route tags
zebra: add support for route tags
bgpd: atomic-aggregate is lost when we aggregate another aggregate
that has atomic-aggregate
bgpd, ospfd, ospf6d, ripd, ripngd, zebra: 'set metric -12' is broken
in the parser
bgpd: Alow gracefull shutdown of peers
bgpd: Add replace-as option to remove-private-as
bgpd, lib: Clarify the different permutations of soft clearing a peer
bgpd, isisd, lib, tests: Overhaul BGP debugs
bgpd: Implement BGP as-override feature
bgpd: Fix BGP_INFO_ATTR_CHANGED being cleared incorrectly
bgpd: Correct a few fuzz failures in BGP
zebra: Fix incorrectly flagged nexthop
bgpd: Save the last message from a peer that caused us to send a
NOTIFICATION

Dinesh Dutt (19):
bgpd: IPv6 Multipath broken with nexthop global address
zebra: Use a fixed route metric when populating kernel
bgpd, doc: Support matching on local preference in route-map
bgpd, doc: Allow route-map policy modifications to also affect route
reflectors.
bgpd, vtysh: Add match interface support to BGP route-map.
ospfd: Don't wait for state change to Exchange to start LSReq
lib, vtysh: Add support for marking a file with appropriate end of
context
zebra: Suppress displaying default config as part of running config
bgpd: Test effect of route-map on received/advertised routes
lib, zebra: Add route-map support for Next Hop Tracking
bgpd, zebra: Use next hop tracking for connected routes too
lib, zebra: allow static routes to use NH's from protocols
zebra: Gather and display detailed info about clients of Zebra
lib, zebra: Honor setting source via route map and pushing that to the
kernel.
lib, ospf6d, zebra: Add ABR support and make ECMP > 4.
lib, ospfd, ospf6d: ospfv3-stub-area-support.patch
bgpd, tests, vtysh: Fix FSM to handle active/passive connections
better
bgpd, lib, vtysh, zebra: Reprocess the trigger points when an attached
route map changes
ospfd: Better handle traffic when system is loaded

Donald Sharp (4):
bgpd, build, zebra: Set MULTIPATH_NUM to 64 when user specifies 0 from
cli
vtysh: service integrated-vtysh-config not being written to file
zebra: Add check to notice when an interface is unnumbered
lib, ospfd, zebra: Fix up some compile issues on *bsd systems

JR Rivers (1):
ospfd: 16.0 rfc2328 compliance

James Li (3):
zebra: Dissallow outside programs to delete Quagga routes
zebra: Notice passed nexthop is ONLINK
ospfd: Add unnumbered interface support

Pradosh Mohapatra (5):
bgpd: cluster-id length equality for multipath
bgpd, doc, lib, zebra: nexthop-tracking in zebra
bgpd: Add a null check in bgp_address_del() function when connected
addresses are removed.
bgpd, lib: Show more meaningful outq value in 'show ip bgp summary'
output.
bgpd: Event-driven route announcement taking into account min route
advertisement interval

Vipin Kumar (17):
bgpd: update delay
bgpd, doc: table-map feature
bgpd, lib, zebra: 'neighbor <if-name> interface' config support in BGP
including RA/Zebra changes.
bgpd: update prefix packing optimizations
bgpd: Make the private AS number check 4 byte compatible.
lib, zebra: Block configuration and installation of martians
ospfd: Support for 'clear ip ospf interface [IFNAME]'
opsf6d: Update router-LSA when nbr's interface-ID changes
ospf6d: Support for 'clear ipv6 ospf6 interface [ifname]
ospf6d: Add the missing ospf6 running check in show cmds
ospfd: Make destination of p2p to multicast for LS-ACKS
ospf6d: LA (local-address) bit related inter-op fix.
ospf6d: Fixing a couple of issues with ospf6_route_remove () routine.
ospf6d: Adding the initialization check in ospfv3_clean()
ospfd: Fix shutdown scenario
bgpd: Add maxmed command
ospf6d: Fix loss of hello's on interface

Vivek Venkatraman (4):
bgpd: Make source interface selection in BGP for nexthop determination
more robust
lib: Some small enhancements to thread and workqueue libraries in
zebra:
bgpd: Changes to improve BGP convergence time:
vtysh: Make ipv6 unicast/multicast address-family work

bgpd/Makefile.am            |    5 +-
bgpd/bgp_advertise.c        |   55 +-
bgpd/bgp_advertise.h        |   29 +
bgpd/bgp_aspath.c           |  176 +++-
bgpd/bgp_aspath.h           |   14 +-
bgpd/bgp_attr.c             |  234 ++---
bgpd/bgp_attr.h             |   12 +-
bgpd/bgp_btoa.c             |    1 +
bgpd/bgp_clist.c            |   15 +-
bgpd/bgp_damp.c             |    1 +
bgpd/bgp_debug.c            | 1121 +++++++++++++++++++-----
bgpd/bgp_debug.h            |   39 +-
bgpd/bgp_ecommunity.c       |    1 +
bgpd/bgp_filter.c           |   31 +-
bgpd/bgp_filter.h           |    4 +-
bgpd/bgp_fsm.c              |  828 ++++++++++++++++--
bgpd/bgp_fsm.h              |   24 +
bgpd/bgp_main.c             |   33 +-
bgpd/bgp_mpath.c            |   61 +-
bgpd/bgp_mpath.h            |    6 +-
bgpd/bgp_mplsvpn.c          |    1 +
bgpd/bgp_network.c          |  141 ++-
bgpd/bgp_network.h          |    2 +-
bgpd/bgp_nexthop.c          | 1151 +++----------------------
bgpd/bgp_nexthop.h          |   42 +-
bgpd/bgp_nht.c              |  517 +++++++++++
bgpd/bgp_nht.h              |   58 ++
bgpd/bgp_open.c             |   25 +-
bgpd/bgp_packet.c           |  857 +++++++++++--------
bgpd/bgp_packet.h           |   14 +-
bgpd/bgp_regex.c            |    2 +
bgpd/bgp_route.c            | 1934
++++++++++++++++++++++++++++++------------
bgpd/bgp_route.h            |   40 +-
bgpd/bgp_routemap.c         | 1039 +++++++++++++++++++----
bgpd/bgp_table.c            |    1 +
bgpd/bgp_table.h            |    1 +
bgpd/bgp_vty.c              | 1926
++++++++++++++++++++++++++++++-----------
bgpd/bgp_vty.h              |    4 +
bgpd/bgp_zebra.c            |  726 ++++++++++++----
bgpd/bgp_zebra.h            |    9 +-
bgpd/bgpd.c                 |  749 ++++++++++++----
bgpd/bgpd.h                 |  139 ++-
configure.ac                |    5 +-
doc/bgpd.texi               |   41 +
doc/next-hop-tracking.txt   |  326 +++++++
doc/routemap.texi           |    4 +
isisd/isisd.c               |    5 +-
lib/Makefile.am             |    4 +-
lib/bitfield.h              |  102 +++
lib/command.c               |    2 +-
lib/command.h               |    9 +-
lib/filter.c                |    9 +
lib/if.c                    |   61 ++
lib/if.h                    |   17 +
lib/libospf.h               |    6 +
lib/log.c                   |   27 +-
lib/log.h                   |   12 -
lib/memtypes.c              |    6 +
lib/nexthop.c               |  168 ++++
lib/nexthop.h               |   93 ++
lib/plist.c                 |   14 +-
lib/prefix.h                |   15 +-
lib/route_types.pl          |   23 +-
lib/routemap.c              |  531 +++++++++++-
lib/routemap.h              |   33 +-
lib/thread.c                |   14 +-
lib/thread.h                |    6 +
lib/workqueue.c             |   37 +-
lib/workqueue.h             |    3 +
lib/zclient.c               |  105 ++-
lib/zclient.h               |    9 +
lib/zebra.h                 |    9 +-
ospf6d/ospf6_abr.c          |  553 ++++++++----
ospf6d/ospf6_abr.h          |    7 +-
ospf6d/ospf6_area.c         |  323 ++++++-
ospf6d/ospf6_area.h         |    7 +-
ospf6d/ospf6_asbr.c         |   92 +-
ospf6d/ospf6_asbr.h         |    1 +
ospf6d/ospf6_flood.c        |    5 +-
ospf6d/ospf6_flood.h        |    2 +
ospf6d/ospf6_interface.c    |   78 +-
ospf6d/ospf6_interface.h    |    8 +-
ospf6d/ospf6_intra.c        |  116 ++-
ospf6d/ospf6_lsa.h          |    1 +
ospf6d/ospf6_lsdb.c         |   35 +-
ospf6d/ospf6_lsdb.h         |    4 +
ospf6d/ospf6_main.c         |    4 +
ospf6d/ospf6_message.c      |   14 +-
ospf6d/ospf6_network.c      |   10 +-
ospf6d/ospf6_network.h      |    2 +-
ospf6d/ospf6_route.c        |  291 ++++++-
ospf6d/ospf6_route.h        |   56 +-
ospf6d/ospf6_spf.c          |  152 ++--
ospf6d/ospf6_spf.h          |    6 +-
ospf6d/ospf6_top.c          |   10 +
ospf6d/ospf6_zebra.c        |  109 ++-
ospf6d/ospf6_zebra.h        |    2 +
ospf6d/ospf6d.c             |    8 +
ospfd/ospf_abr.h            |    1 -
ospfd/ospf_asbr.c           |    5 +-
ospfd/ospf_asbr.h           |    3 +-
ospfd/ospf_dump.c           |    2 +-
ospfd/ospf_interface.c      |   13 +-
ospfd/ospf_lsa.c            |   45 +-
ospfd/ospf_main.c           |    1 +
ospfd/ospf_network.c        |   36 +
ospfd/ospf_nsm.c            |    3 +-
ospfd/ospf_packet.c         |  259 +++---
ospfd/ospf_route.c          |    2 +-
ospfd/ospf_routemap.c       |  223 ++++-
ospfd/ospf_spf.c            |    7 -
ospfd/ospf_vty.c            |  199 ++++-
ospfd/ospf_vty.h            |    1 +
ospfd/ospf_zebra.c          |   48 +-
ospfd/ospfd.c               |    2 +
ospfd/ospfd.h               |    9 +-
ripd/rip_routemap.c         |   51 +-
ripngd/ripng_routemap.c     |   24 +-
tests/aspath_test.c         |    1 +
tests/bgp_capability_test.c |    9 +-
tests/bgp_mp_attr_test.c    |    9 +-
tests/bgp_mpath_test.c      |    4 +-
tests/ecommunity_test.c     |    1 +
vtysh/extract.pl.in         |    6 +-
vtysh/vtysh.c               |  159 +++-
vtysh/vtysh.h               |    4 +-
vtysh/vtysh_config.c        |    2 +-
vtysh/vtysh_main.c          |   42 +-
zebra/Makefile.am           |    8 +-
zebra/connected.c           |   33 +-
zebra/connected.h           |    1 +
zebra/debug.c               |   30 +
zebra/debug.h               |    3 +
zebra/if_netlink.c          |    1 +
zebra/if_sysctl.c           |    1 +
zebra/interface.c           |   35 +
zebra/ioctl.c               |    1 +
zebra/kernel_null.c         |    1 +
zebra/kernel_socket.c       |    1 +
zebra/redistribute.c        |   50 +-
zebra/redistribute_null.c   |    1 +
zebra/rib.h                 |  120 +--
zebra/rt_netlink.c          |  117 ++-
zebra/rt_netlink.h          |    3 +-
zebra/rtadv.c               |   81 +-
zebra/rtread_netlink.c      |    1 +
zebra/rtread_sysctl.c       |    1 +
zebra/zebra_fpm_netlink.c   |    8 +-
zebra/zebra_rib.c           |  694 ++++++++++-----
zebra/zebra_rnh.c           |  761 +++++++++++++++++
zebra/zebra_rnh.h           |   54 ++
zebra/zebra_rnh_null.c      |   21 +
zebra/zebra_routemap.c      |  953 ++++++++++++++++++++-
zebra/zebra_vty.c           | 1976
+++++++++++++++++++++++++++++++++++++------
zebra/zserv.c               |  562 ++++++++++--
zebra/zserv.h               |   51 ++
156 files changed, 17450 insertions(+), 4950 deletions(-)
create mode 100644 bgpd/bgp_nht.c
create mode 100644 bgpd/bgp_nht.h
create mode 100644 doc/next-hop-tracking.txt
create mode 100644 lib/bitfield.h
create mode 100644 lib/nexthop.c
create mode 100644 lib/nexthop.h
mode change 100755 => 100644 lib/route_types.pl
create mode 100644 zebra/zebra_rnh.c
create mode 100644 zebra/zebra_rnh.h
create mode 100644 zebra/zebra_rnh_null.c

--
1.9.1


_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev




_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to