I'm planning on backing this patch out on this coming tuesday, unless a fix
get's put forth.  It creates a crash.

donald

On Thu, Dec 17, 2015 at 3:03 PM, Joakim Tjernlund <
[email protected]> wrote:

> On Thu, 2015-12-17 at 19:50 +0000, Joakim Tjernlund wrote:
> > On Thu, 2015-12-17 at 14:11 -0500, Donald Sharp wrote:
> > > Joakim :
> > >
> > > I am experiencing issues with an ospf crash associated with this bug:
> > >
> > > commit 5c1791f28e2e831e4e9b92c3c2f7d8ed832cb968
> > > Author: Joakim Tjernlund <[email protected]>
> > > Date:   Fri Apr 25 14:36:16 2014 +0200
> > >
> > >     ospfd: PointToPoint neighbors are identified by router ID
> > >
> > >     According to RFC 2328, section 10.5  PointToPoint neighbors
> > >     should be identified by router ID instead of source IP address.
> > >
> > >     Signed-off-by: Joakim Tjernlund <[email protected]>
> > >
> > >
> > > My reproduction:
> > >
> > > Starting Config:
> > > interface swp1
> > >  ip address 192.168.39.1/24
> > >  ipv6 address fc00:192:168:1::101/64
> > >  ipv6 nd suppress-ra
> > >  link-detect
> > > !
> > > !
> > > router ospf
> > >  network 192.168.39.0/24 area 0.0.0.0
> > > !
> > >
> >
> > I had a look at this and I cannot see what's up here.
> > However, the patch was written long ago but just recently applied.
> > It was was also written for real PtoP links and from what I can tell you
> > are using a ethernet links as ptop I/Fs which I think is a fairly
> > new addition to Q. I am just guessing here, but I suspect there is
> > something wrong with the feature which lets you use eth as PtoP links.
>
> Actually, there is a history to this patch:
>
> http://www.gossamer-threads.com/lists/quagga/dev/26063?do=post_view_threaded
>  http://comments.gmane.org/gmane.network.quagga.devel/7421
> The first version I wrote was this one:
>  https://lists.quagga.net/pipermail/quagga-dev/2009-November/007443.html
>
> That is all can find, maybe Feng Lu can fill in the blanks?
>
>  Jocke
>
> >
> >  Jocke
> >
> > > Sequence of events to make it happen:
> > > root@cumulus:~# vtysh
> > >
> > > Hello, this is Quagga (version 0.99.25-dev).
> > > Copyright 1996-2005 Kunihiro Ishiguro, et al.
> > >
> > > cumulus# conf t
> > > cumulus(config)# int swp1
> > > cumulus(config-if)# ip ospf network point-to-point
> > > Warning: closing connection to ospfd because of an I/O error!
> > > cumulus(config-if)#
> > >
> > > The decode:
> > >
> > > (gdb) bt
> > > #0  0x00007f0ee417c165 in raise () from /lib/x86_64-linux-gnu/libc.so.6
> > > #1  0x00007f0ee417f3e0 in abort () from /lib/x86_64-linux-gnu/libc.so.6
> > > #2  0x00007f0ee4b507ec in core_handler (signo=<optimized out>,
> siginfo=<optimized out>,
> > >     context=<optimized out>) at sigevent.c:240
> > > #3  <signal handler called>
> > > #4  0x0000000000cfbec0 in ?? ()
> > > #5  0x00007f0ee4b3f6b1 in route_node_new (table=0xcfa7e0) at table.c:57
> > > #6  route_node_set (table=table@entry=0xcfa7e0, 
> > > prefix=prefix@entry=0x7ffcec6837d0)
> at table.c:66
> > > #7  0x00007f0ee4b3fae3 in route_node_get (table=table@entry=0xcfa7e0,
> p=p@entry=0x7ffcec6837d0)
> > >     at table.c:312
> > > #8  0x00007f0ee4db2349 in ospf_lsdb_add (lsdb=lsdb@entry=0xcfa170,
> lsa=lsa@entry=0xcf9070)
> > >     at ospf_lsdb.c:122
> > > #9  0x00007f0ee4db160d in ospf_ls_retransmit_add (nbr=nbr@entry=0xcfa110,
> lsa=lsa@entry=0xcf9070)
> > >     at ospf_flood.c:875
> > > #10 0x00007f0ee4db1828 in ospf_flood_through_interface (lsa=0xcf9070,
> inbr=0x0, oi=0xcf8490)
> > >     at ospf_flood.c:475
> > > #11 ospf_flood_through_interface (oi=0xcf8490, inbr=0x0, lsa=0xcf9070)
> at ospf_flood.c:345
> > > #12 0x00007f0ee4db1b3f in ospf_flood_through_area 
> > > (area=area@entry=0xcf7f50,
> inbr=inbr@entry=0x0,
> > >     lsa=lsa@entry=0xcf9070) at ospf_flood.c:583
> > > #13 0x00007f0ee4da9160 in ospf_router_lsa_refresh (lsa=0xcfb760) at
> ospf_lsa.c:937
> > > #14 ospf_lsa_refresh (ospf=<optimized out>, lsa=0xcfb760) at
> ospf_lsa.c:3630
> > > #15 0x00007f0ee4da9a3f in ospf_router_lsa_update_area (area=0xcf7f50)
> at ospf_lsa.c:958
> > > #16 0x00007f0ee4d9a2ac in ism_change_state (state=1, oi=0xcf8490) at
> ospf_ism.c:580
> > > #17 ospf_ism_event (thread=<optimized out>) at ospf_ism.c:628
> > > #18 0x00007f0ee4b3d0fc in thread_call (thread=thread@entry=0x7ffcec683b58)
> at thread.c:1252
> > > #19 0x00007f0ee4b3d1f8 in funcname_thread_execute (m=<optimized out>,
> func=<optimized out>,
> > >     arg=arg@entry=0xcf8490, val=val@entry=7,
> > >     funcname=funcname@entry=0x7f0ee4dc85d4 "ospf_ism_event",
> > >     schedfrom=schedfrom@entry=0x7f0ee4dd5b88 "ospf_vty.c",
> fromln=5469) at thread.c:1309
> > > #20 0x00007f0ee4db98a0 in ip_ospf_network (self=<optimized out>,
> vty=<optimized out>,
> > >     argc=<optimized out>, argv=<optimized out>) at ospf_vty.c:5469
> > > #21 0x00007f0ee4b3876d in cmd_execute_command_real (vline=vline@entry
> =0xcf9850,
> > >     filter=filter@entry=FILTER_RELAXED, vty=vty@entry=0xcf9c70,
> cmd=cmd@entry=0x0)
> > >     at command.c:2702
> > > #22 0x00007f0ee4b39d0f in cmd_execute_command (vline=vline@entry=0xcf9850,
> vty=vty@entry=0xcf9c70,
> > >     cmd=cmd@entry=0x0, vtysh=vtysh@entry=0) at command.c:2751
> > > #23 0x00007f0ee4b33a97 in vty_command (vty=vty@entry=0xcf9c70,
> > >     buf=0xcf9f00 "ip ospf network point-to-point ") at vty.c:420
> > > #24 0x00007f0ee4b33d4e in vty_execute (vty=vty@entry=0xcf9c70) at
> vty.c:1286
> > > #25 0x00007f0ee4b33f17 in vtysh_read (thread=<optimized out>) at
> vty.c:2169
> > > ---Type <return> to continue, or q <return> to quit---
> > > #26 0x00007f0ee4b3d0fc in thread_call (thread=thread@entry=0x7ffcec6843a8)
> at thread.c:1252
> > > #27 0x0000000000401b5e in main (argc=4, argv=0x7ffcec684538) at
> ospf_main.c:340
> > > (gdb)
> > >
> > > thanks!
> > >
> > > donald
> >
> > _______________________________________________
> > Quagga-dev mailing list
> > [email protected]
> > https://lists.quagga.net/mailman/listinfo/quagga-dev
>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to