Vincent / Olivier
On 20 Jan 2016, at 2:54, Vincent JARDIN wrote:
My concerns, taking my TE patches as examples, is that it is hard to
work out of the Quagga Git Tree without the possibility to commit
directly on git. We are in the case that original patches have been
patches (patch of patch) and need new corrections (patch of patch of
patch). Which is hard to follow and then to prepare a correct set of
clean patches to be apply on the main tree.
+1
So, IMHO, Gerit seems to be the good tools as during the review, we
could add some corrections/modifications without the necessity to
create
a new set of patches. Then, create a dedicated branch per set of
patches
(e.g. Paul do that for TE with quagga-lls_te branch) will be fine as
it
allows an easy isolation per topics. Now, it remains the permissions
management, but if Atlassian allows that, it will be fine.
I'd like to avoid commercial solutions like Atlassian since they can
change their policies. However, if Atlassian is *much* better and good
enough for upcoming 5y, let's go with Atlassian.
I don’t know if they are much better, I only commented that they have
the cool feature
on their git server to set permissions per branch. - and overall I like
their tools.
But I have not used their code review tool (Atlassian Crucible)
Martin,
do you have a breakdown analyzing Atlassian+bitbucket vs
git+gerrit+jenkins? I guess, you did check it and you saw benefits,
your inputs would be welcomed.
I can’t make a statement about Gerrit as I have no experience on it.
As I said on the call,
I’ll take some time and try it a bit. Happy to talk about my
impressions at the next call.
Also, I’m not sure if there is any reason why things can’t be mixed
- i.e. Atlassian Bitbucket
for git with gerrit for code review.
- Martin
Regards,
Olivier
Le 20/01/2016 01:20, Martin Winter a écrit :
Pushing patchwork patches into a git would be trivial for me to do
(ie
after some passed initial test as patches)
If the community likes this, then let me know and we could figure
out
details (branch? Potentially create new branch for each patchwork?)
BTW: Atlassian git (Bitbucket server) allows permission per branch -
would be easy to lock main branch(es) to maintainers without locking
everything.
- Martin
On Tue, Jan 19, 2016 at 3:36 PM, Vincent JARDIN
<[email protected] <mailto:[email protected]>> wrote:
On 19/01/2016 20:59, Kei Nohguchi wrote:
the original reason, or pain, with the patchwork?
benefit of patchwork: simple
issues of patchwork: very limited tracking and very light
integration with git (git review is missing).
_______________________________________________
Quagga-dev mailing list
[email protected] <mailto:[email protected]>
https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
--
logo Orange <http://www.orange.com>
Olivier Dugeon
Senior research engineer in QoS and network control
Open Source Referent
Orange/IMT/OLN/WTC/IEE/OPEN
fixe : +33 2 96 07 28 80
mobile : +33 6 82 90 37 85
[email protected] <mailto:[email protected]>
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
