It's baby steps in my mind. I left the ability to use select over poll, currently, was because poll causes a tiny bit higher load for smaller working sets. I didn't go directly to kqueue and epoll because I didn't want to have to implement freebsd's version.
I'll rework commit messages a bit more this evening or tomorrow. I might rework 5 a bit more as well. I'm not totally happy with it yet though. donald On Sat, Mar 5, 2016 at 10:15 AM, Paul Jakma <p...@jakma.org> wrote: > On Fri, 4 Mar 2016, Donald Sharp wrote: > > This patch originated w/ Hannes Hofer <hho...@barracuda.com>. >> I've taken the patch fixed some bugs and reworked the code >> to allow both poll and select to be choosen at compile time. >> > > Couple of comments (with one comment effectively nested inside the first > ;) ): > > I'd really like a more detailed commit message on stuff like this. > Starting with at least some kind of rationale, i.e., why do we care about > supporting poll over select? Why don't we go directly to kqueue and epoll? > > regards, > -- > Paul Jakma p...@jakma.org @pjakma Key ID: 64A2FF6A > Fortune: > It's currently a problem of access to gigabits through punybaud. > -- J. C. R. Licklider >
_______________________________________________ Quagga-dev mailing list Quagga-dev@lists.quagga.net https://lists.quagga.net/mailman/listinfo/quagga-dev
