Paul,
from the testing side, I would appreciate if you could submit them in
multiple patches into
the next proposed branch. I worry a long git bisect nightmare to find
the bad commits. (also,
not sure if you checked if each patch was successful on it’s own on my
CI system).
My preferred way to work through this would be to submit one set (from
one committer) into
a proposed branch, then wait until the CI system gives the OK (or if not
then get them fixed),
then push the next set etc..
(I assume that most/all of these patches are not disputed from the
functionality and the
further review is based mostly on the implementation)
But don’t let me stop you… I highly appreciate the long list of
patches queued up.
If this is too painful, then just go ahead on what works best for you
and I’ll find
a way.
- Martin
On 6 Jun 2016, at 12:35, Paul Jakma wrote:
On Mon, 6 Jun 2016, Jafar Al-Gharaibeh wrote:
Paul,
Great to see this long list of patches queued up finally. Good
work, your effort is appreciated.
No worries.
Note that these are 'proposed'. The next step is to get final reviews
done and sort into 'accepted' or 'pushback' (i.e. to the contributor).
The latter can occur cause of nits, just unfortunate merging issues
the integrator couldn't resolve, architectural issues, etc.
I have a feeling a lot of the friction around at the moment can be
removed just by working through the pending stuff. Which should then
make for a calmer environment in which to address any remaining
issues.
regards,
--
Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
When you dial a wrong number you never get a busy signal.
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
