Acked-by: Donald Sharp <[email protected]> One thing I would like to start thinking about is fixing the semantics of the zapi such that client protocols don't have to worry about parsing the stream data. It should be handled by the lib/zclient.c and calling the appropriate lib/*.c functions to announce new information. This would reduce the cut-n-paste decoding that is done by every client protocol.
donald On Tue, Jun 14, 2016 at 2:06 PM, Christian Franke < [email protected]> wrote: > From: Christian Franke <[email protected]> > > zebra_interface_state_read can return NULL in cornercases. The other > daemons check for this, so should bgpd. > > Signed-off-by: Christian Franke <[email protected]> > --- > bgpd/bgp_zebra.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/bgpd/bgp_zebra.c b/bgpd/bgp_zebra.c > index d0b9216..a1f42f9 100644 > --- a/bgpd/bgp_zebra.c > +++ b/bgpd/bgp_zebra.c > @@ -100,6 +100,9 @@ bgp_interface_delete (int command, struct zclient > *zclient, > > s = zclient->ibuf; > ifp = zebra_interface_state_read (s, vrf_id); > + if (! ifp) > + return 0; > + > ifp->ifindex = IFINDEX_INTERNAL; > > if (BGP_DEBUG(zebra, ZEBRA)) > -- > 2.8.0 > > > _______________________________________________ > Quagga-dev mailing list > [email protected] > https://lists.quagga.net/mailman/listinfo/quagga-dev >
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
