Acked-by: Jafar Al-Gharaibeh <[email protected]>
On 6/20/2016 12:58 PM, Quentin Young wrote:
Some bitfields for zebra_debug_* flags were being modified
with bitwise operators instead of the purpose-built macros
in lib/zebra.h. Changed such instances to use the macros.
Signed-off-by: Quentin Young <[email protected]>
---
zebra/debug.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/zebra/debug.c b/zebra/debug.c
index 537c476..1004c95 100644
--- a/zebra/debug.c
+++ b/zebra/debug.c
@@ -97,8 +97,8 @@ DEFUN (debug_zebra_packet,
"Debug option set for zebra packet\n")
{
zebra_debug_packet = ZEBRA_DEBUG_PACKET;
- zebra_debug_packet |= ZEBRA_DEBUG_SEND;
- zebra_debug_packet |= ZEBRA_DEBUG_RECV;
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_SEND);
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_RECV);
return CMD_SUCCESS;
}
@@ -113,11 +113,11 @@ DEFUN (debug_zebra_packet_direct,
{
zebra_debug_packet = ZEBRA_DEBUG_PACKET;
if (strncmp ("send", argv[0], strlen (argv[0])) == 0)
- zebra_debug_packet |= ZEBRA_DEBUG_SEND;
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_SEND);
if (strncmp ("recv", argv[0], strlen (argv[0])) == 0)
- zebra_debug_packet |= ZEBRA_DEBUG_RECV;
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_RECV);
if (strncmp ("detail", argv[0], strlen (argv[0])) == 0)
- zebra_debug_packet |= ZEBRA_DEBUG_DETAIL;
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_DETAIL);
return CMD_SUCCESS;
}
@@ -133,10 +133,10 @@ DEFUN (debug_zebra_packet_detail,
{
zebra_debug_packet = ZEBRA_DEBUG_PACKET;
if (strncmp ("send", argv[0], strlen (argv[0])) == 0)
- zebra_debug_packet |= ZEBRA_DEBUG_SEND;
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_SEND);
if (strncmp ("recv", argv[0], strlen (argv[0])) == 0)
- zebra_debug_packet |= ZEBRA_DEBUG_RECV;
- zebra_debug_packet |= ZEBRA_DEBUG_DETAIL;
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_RECV);
+ SET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_DETAIL);
return CMD_SUCCESS;
}
@@ -220,9 +220,9 @@ DEFUN (no_debug_zebra_packet_direct,
"Debug option set for send packet\n")
{
if (strncmp ("send", argv[0], strlen (argv[0])) == 0)
- zebra_debug_packet &= ~ZEBRA_DEBUG_SEND;
+ UNSET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_SEND);
if (strncmp ("recv", argv[0], strlen (argv[0])) == 0)
- zebra_debug_packet &= ~ZEBRA_DEBUG_RECV;
+ UNSET_FLAG(zebra_debug_packet, ZEBRA_DEBUG_RECV);
return CMD_SUCCESS;
}
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
