[quagga-dev 15856] Quagga round-8: review/comments/sanity-check on proposed patches

[Paul Jakma]

Hi,

I've tried to collate the bulk of the outstanding patches (least up to 
the time I started) into a 'proposed' head for round-8, so we can review 
them and then further sort them out into:

- the tentative 'accepted' patches (to then have NetDEF / OSR do their
  usual smoke-testing on before final integration)

- patches with 'nits' that could be quickly addressed and could still go
  in in this round.

- patches to 'pushback' with objections, that likely need further work
  or discussion, or abandonment of the patch.

The git refs for the commits proposed for round-8 can be found under:

  http://git.savannah.gnu.org/cgit/quagga.git/refs/

The raw input commits are Donald Sharp's take-3, collating a huge bunch 
of Cumulus' work, and commits from patchwork:

 
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/donald-take-3
 
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/patchwork

I've linearised them, with various fixups and edits, into a 
fast-forward-mergable branch as:

 
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/ff

I have /preliminary/ 'nits' and 'pushback' heads based on comments 
already made, for commits that might have otherwise caused me merging 
issues if I'd put them in 'ff' (least, at that point of merging stuff 
anyway):

  
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/nits
  
http://git.savannah.gnu.org/cgit/quagga.git/log/?h=volatile/patch-tracking/8/proposed/pushback

Note: It could well be further commits from 'ff' get sorted onto one of 
those as result of the next review phase.

The next phase is to review these commits:

- Contributors should examine their commits and check I havn't mismerged
  them (happens sometimes).

- Generally, give comments on any issues.

A fetch and then 'gitk --all' may be a good way to see what is on what 
branch (if you don't view all the branches together, gitk won't show you 
where the forking point is - 'pushback' is forked from 'ff', and 
'pushback' is only really the commits /not/ in common with 'ff'). Or do 
a 'git log $PREF/ff..$PREF/nits' where PREF is something like:

  <your remote name for quagga repo>/volatile/patch-tracking/8/proposed/

The list of commits:

Ayan Banerjee a...@cumulusnetworks.com:
  ospfd: Limit the number of interfaces serviced at one time

Ayan Banerjee a...@cumulusnetworks.com:
  ospfd: Ensure that OSPF can send out multiple packets per thread

Vipin Kumar vi...@cumulusnetworks.com:
  bgpd: Add maxmed command

Donald Sharp sha...@cumulusnetworks.com:
  bgpd: Fix write quanta to a reasonable number.

Dinesh Dutt dd...@cumulusnetworks.com:
  lib, ospfd, ospf6d: ospfv3-stub-area-support.patch

Dinesh Dutt dd...@cumulusnetworks.com:
  lib, ospf6d, zebra: Add ABR support and make ECMP > 4.

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd, isisd, lib, tests: Overhaul BGP debugs

Vivek Venkatraman vi...@cumulusnetworks.com:
  bgpd: Changes to improve BGP convergence time:

Vivek Venkatraman vi...@cumulusnetworks.com:
  lib: Some small enhancements to thread and workqueue libraries in zebra:

Dinesh Dutt dd...@cumulusnetworks.com:
  lib, zebra: Honor setting source via route map and pushing that to the kernel.

Dinesh Dutt dd...@cumulusnetworks.com:
  zebra: Static NHT fixes

Dinesh Dutt dd...@cumulusnetworks.com:
  lib, zebra: allow static routes to use NH's from protocols

Dinesh Dutt dd...@cumulusnetworks.com:
  lib, zebra: Add route-map support for Next Hop Tracking

Dinesh Dutt dd...@cumulusnetworks.com:
  bgpd: Test effect of route-map on received/advertised routes

Vipin Kumar vi...@cumulusnetworks.com:
  lib, zebra: Block configuration and installation of martians

Vipin Kumar vi...@cumulusnetworks.com:
  bgpd: update prefix packing optimizations

Pradosh Mohapatra pmoha...@cumulusnetworks.com:
  bgpd: Event-driven route announcement taking into account min route 
advertisement interval

Donald Sharp sha...@cumulusnetworks.com:
  bgpd: Correctly install non LL route into zebra

Vipin Kumar vi...@cumulusnetworks.com:
  bgpd, doc: table-map feature

Vipin Kumar vi...@cumulusnetworks.com:
  bgpd: update delay

Pradosh Mohapatra pmoha...@cumulusnetworks.com:
  bgpd: cluster-id length equality for multipath

Dinesh Dutt dd...@cumulusnetworks.com:
  lib, vtysh: Add support for marking a file with appropriate end of context

Ayan Banerjee a...@cumulusnetworks.com:
  ospfd: Ensure deletion is clean

Paul Jakma p...@opensourcerouting.org:
  vrf: Add message to ZServ to notify clients of valid VRF Ids

Paul Jakma paul.ja...@hpe.com:
  zebra: Update news with the status of link-detect and the global default

Paul Jakma p...@jakma.org:
  zebra: Add command to configure default for link-state, and make it sticky

Dinesh G Dutt dd...@cumulusnetworks.com:
  zebra: Set link-detect on by default

Paul Jakma paul.ja...@hpe.com:
  bgpd: Squash spurious "unknown afi" log messages

Dinesh Dutt dd...@cumulusnetworks.com:
  bgpd, vtysh: Add match interface support to BGP route-map.

Vivek Venkatraman vi...@cumulusnetworks.com:
  bgpd: Handle some route map corner cases

Dinesh G Dutt dd...@cumulusnetworks.com:
  bgpd, lib, vtysh, zebra: Reprocess the trigger points when an attached route 
map changes

Vipin Kumar vi...@cumulusnetworks.com:
  bgpd, lib, zebra: 'neighbor <if-name> interface' config support in BGP 
including RA/Zebra changes.

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Implement BGP as-override feature

James Li j...@cumulusnetworks.com:
  ospfd: Add unnumbered interface support

Dinesh Dutt dd...@cumulusnetworks.com:
  bgpd, zebra: Use next hop tracking for connected routes too

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: crash if attributes alone consume > 4096 bytes

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Improve peer scaling

dwal...@cumulusnetworks.com dwal...@cumulusnetworks.com:
  bgpd: Save the last message from a peer that caused us to send a NOTIFICATION

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: don't count a route with an unreachable nexthop in PfxRcd

Donald Sharp sha...@cumulusnetworks.com:
  ospf6d: Fix double increment of Sequence Number

Donald Sharp sha...@cumulusnetworks.com:
  zebra: Fix some warnings found during compile.

Vipin Kumar vi...@cumulusnetworks.com:
  osfd: Make OSPF compliant to the last sentence of this section in RFC 2328

Daniel Walton dwal...@cumulusnetworks.com:
  zebra: Fix incorrectly flagged nexthop

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Correct a few fuzz failures in BGP

Vipin Kumar vi...@cumulusnetworks.com:
  ospf6d: Fix loss of hello's on interface

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Fix BGP_INFO_ATTR_CHANGED being cleared incorrectly

James Li j...@cumulusnetworks.com:
  zebra: Notice passed nexthop is ONLINK

Donald Sharp sha...@cumulusnetworks.com:
  zebra: Add check to notice when an interface is unnumbered

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd, lib: Clarify the different permutations of soft clearing a peer

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Alow gracefull shutdown of peers

Dinesh Dutt dd...@cumulusnetworks.com:
  zebra: Gather and display detailed info about clients of Zebra

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd, ospfd, ospf6d, ripd, ripngd, zebra: 'set metric -12' is broken in the 
parser

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: atomic-aggregate is lost when we aggregate another aggregate that has 
atomic-aggregate

Piotr Chytła p...@packetconsulting.pl:
  ripd, ripngd: add support for route tags

Piotr Chytła p...@packetconsulting.pl:
  zebra: add support for route tags

Piotr Chytła p...@packetconsulting.pl:
  bgpd, vtysh: Add support for route tags

Piotr Chytła p...@packetconsulting.pl:
  ospfd, vtysh: Add support for Route tags

Piotr Chytła p...@packetconsulting.pl:
  bgpd, lib, ospfd, zebra: Add ability to read/write tag value

Piotr Chytła p...@packetconsulting.pl:
  zebra: Add internal support for route tags

Donald Sharp sha...@cumulusnetworks.com:
  vtysh: service integrated-vtysh-config not being written to file

Dinesh Dutt dd...@cumulusnetworks.com:
  zebra: Suppress displaying default config as part of running config

Donald Sharp sha...@cumulusnetworks.com:
  bgpd: flag paths for multipath if we RX link-local and global nexthops

Daniel Walton dwal...@cumulusnetworks.com:
  ospfd: "show ip ospf neighbor" header spacing

Vivek Venkatraman vi...@cumulusnetworks.com:
  bgpd: Make source interface selection in BGP for nexthop determination more 
robust

Vipin Kumar vi...@cumulusnetworks.com:
  ospf6d: Adding the initialization check in ospfv3_clean()

Vipin Kumar vi...@cumulusnetworks.com:
  ospf6d: Fixing a couple of issues with ospf6_route_remove () routine.

Vipin Kumar vi...@cumulusnetworks.com:
  ospf6d: LA (local-address) bit related inter-op fix.

Dinesh Dutt dd...@cumulusnetworks.com:
  ospfd: Don't wait for state change to Exchange to start LSReq

Daniel Walton dwal...@cumulusnetworks.com:
  ospfd: Fix no ip ospf hello-interval

Vipin Kumar vi...@cumulusnetworks.com:
  ospfd: Make destination of p2p to multicast for LS-ACKS

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Display BGP paths with unreachable nexthops as invalid

Daniel Walton dwal...@cumulusnetworks.com:
  ospf6d: We should accept long form of "no redistribute"

Vipin Kumar vi...@cumulusnetworks.com:
  ospf6d: Add the missing ospf6 running check in show cmds

Vipin Kumar vi...@cumulusnetworks.com:
  ospf6d: Support for 'clear ipv6 ospf6 interface [ifname]

Vipin Kumar vi...@cumulusnetworks.com:
  opsf6d: Update router-LSA when nbr's interface-ID changes

Vipin Kumar vi...@cumulusnetworks.com:
  ospfd: Support for 'clear ip ospf interface [IFNAME]'

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Add [bestpath|multipath] option to 'show ip bgp x.x.x.x'

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Add clear command to force a bestpath recalculation and 
re-advertisement of a prefix

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Fix aggregation issues found via ANVL

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: iBGP multipath is broken if 'bgp deterministic-med' is enabled.

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Make aspath_highest 4-byte compatible for private AS

Paul Jakma paul.ja...@hpe.com:
  bgpd: Fix use after free in aspath_prepend with confeds

Vipin Kumar vi...@cumulusnetworks.com:
  bgpd: Make the private AS number check 4 byte compatible.

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Make "no redistribute" always remove the redistribute statement

Daniel Walton dwal...@cumulusnetworks.com:
  ospf6d, ripd, vtysh: Fix "no set metric" for ospf6 and RIP

James Li j...@cumulusnetworks.com:
  zebra: Dissallow outside programs to delete Quagga routes

Dinesh Dutt dd...@cumulusnetworks.com:
  bgpd, doc: Allow route-map policy modifications to also affect route 
reflectors.

Dinesh Dutt dd...@cumulusnetworks.com:
  bgpd: Support matching on local preference in route-map

Pradosh Mohapatra pmoha...@cumulusnetworks.com:
  bgpd: Show more meaningful outq value in 'show ip bgp summary' output.

vivek vi...@cumulusnetworks.com:
  vtysh: Make ipv6 unicast/multicast address-family work

Paul Jakma paul.ja...@hpe.com:
  *: Fix duplicate commands from view/enable node consolidation

Paul Jakma paul.ja...@hpe.com:
  lib: keep hash of node's commands to detect duplicate installs

Pradosh Mohapatra pmoha...@cumulusnetworks.com:
  bgpd: Add a null check in bgp_address_del() function when connected addresses 
are removed.

Pradosh Mohapatra pmoha...@cumulusnetworks.com:
  bgpd, doc, lib, zebra: nexthop-tracking in zebra

Dinesh Dutt dd...@cumulusnetworks.com:
  bgpd: IPv6 Multipath broken with nexthop global address

Ayan Banerjee a...@cumulusnetworks.com:
  bgpd: Enable support for BGP IPV6 multipath.

Ayan Banerjee a...@cumulusnetworks.com:
  zebra: ipv6 multipath support

Paul Jakma paul.ja...@hpe.com:
  zebra: *addattr should use size_t len args, quell signed v unsigned warning

Paul Jakma paul.ja...@hpe.com:
  vtysh: auto-generated vtysh_cmd.c file should depend on its creator

Avneesh Sachdev avne...@sproute.com:
  zebra: add developer test functions for FPM code

Avneesh Sachdev avne...@sproute.com:
  build: support for "development build"

Avneesh Sachdev avne...@sproute.com:
  doc: add blurb on use of protobuf with FPM

Avneesh Sachdev avne...@sproute.com:
  zebra: optionally use protobuf with FPM

Avneesh Sachdev avne...@sproute.com:
  fpm: Add protobuf support for FPM.

Avneesh Sachdev avne...@sproute.com:
  build: turn off automake portability warnings

Avneesh Sachdev avne...@sproute.com:
  qpb: Add support for protobuf.

Paul Jakma p...@jakma.org:
  HACKING: Document how to add standard copyright claims to files

Paul Jakma paul.ja...@hpe.com:
  HACKING: New code _MUST_ use a bounded-buffer in handling untrusted data.

Paul Jakma p...@jakma.org:
  HACKING: Note that "Signed-off-by" not used for authorship/rights info

Paul Jakma p...@jakma.org:
  HACKING: Add required reading section & commit should give full rights details

Paul Jakma p...@jakma.org:
  HACKING: Fix internal section links

Paul Jakma p...@jakma.org:
  HACKING: Update HACKING with anything relevant from pending and prune

David Lamparter equi...@opensourcerouting.org:
  bgpd: ditch unused bgp_node_*() functions

David Lamparter equi...@opensourcerouting.org:
  bgpd: divorce router-id logic from CLI & zebra

David Lamparter equi...@opensourcerouting.org:
  bgpd: minor header/API clean up

David Lamparter equi...@opensourcerouting.org:
  isisd: drop unused per-type metric values

Christian Franke nob...@nowhere.ws:
  isisd: API: area (L1), domain (L2) passwords

Christian Franke nob...@nowhere.ws:
  isisd: API: timers (LSP, SPF)

Christian Franke nob...@nowhere.ws:
  isisd: API: LSP-MTU & area level

David Lamparter equi...@opensourcerouting.org:
  isisd: API: timers (IIH, CSNP, PSNP)

Christian Franke nob...@nowhere.ws:
  isisd: API: circuit password

Christian Franke nob...@nowhere.ws:
  isisd: API: basic area config

David Lamparter equi...@opensourcerouting.org:
  isisd: API: basic circuit config

Philippe Guibert philippe.guib...@6wind.com:
  bgpd: Add new configuration cli for graceful restart.

Lou Berger lber...@labn.net:
  lib: add AF_ETHERNET/AFI_ETHER

Lou Berger lber...@labn.net:
  lib: dump memory stats on core

Lou Berger lber...@labn.net:
  bgpd: Add flag to not change e{u,g}id on startup and run as unprivileged user

Lou Berger lber...@labn.net:
  bgp: add "debug bgp allow-martians" next hops and related code/commands

Lou Berger lber...@labn.net:
  lib: fix memory leak in zprivs_caps_init

Igor Ryzhov iryz...@nfware.com:
  bgpd: fix wrong help strings of "match peer" and "no match peer" commands

Colin Petrie cpet...@ripe.net:
  bgpd: fix MRT table dumps for locally-originated routes

Jafar Al-Gharaibeh ja...@atcorp.com:
  pimd: send pim prune via correct interface when rpf upstream interface for a 
source changes

Andrej Ota and...@ota.si:
  bgpd: fix BGP IPv6 route map error

Olivier Dugeon olivier.dug...@orange.com:
  ospfd: Add support Router Capabilities support to OSPF

Olivier Dugeon olivier.dug...@orange.com:
  doc: Update documentation for Traffic Engineering

Olivier Dugeon olivier.dug...@orange.com:
  isisd: Add support of Traffic Engineering

Olivier Dugeon olivier.dug...@orange.com:
  ospfd: Update Traffic Engineering support

Olivier Dugeon olivier.dug...@orange.com:
  vtysh: Add support of new link-params CLI

Olivier Dugeon olivier.dug...@orange.com:
  zebra: Add link parameters support to Zebra

Olivier Dugeon olivier.dug...@orange.com:
  lib: Add new if_link_params structure

Paul Jakma p...@opensourcerouting.org:
  lib: consolidate ntohf/htonf from ospfd/isisd TE to lib/network

Paul Jakma p...@opensourcerouting.org:
  lib/stream: add float/double <-> IEEE-754 single/double mux/demuxers

Christian Franke nob...@nowhere.ws:
  zebra: count iface up/down events and keep last time of their occurrence

Christian Franke nob...@nowhere.ws:
  lib: add event_counter

Christian Franke nob...@nowhere.ws:
  lib: add api method to read current config path

Christian Franke nob...@nowhere.ws:
  lib: use constant to replace magic value for length of quagga_timestamp

Pawel Wieczorkiewicz pwieczorkiew...@suse.de:
  build: detect and create AM_SILENT_RULES macro if needed

Donald Sharp sha...@cumulusnetworks.com:
  lib: Remove unnecessary parentheses

Donald Sharp sha...@cumulusnetworks.com:
  bgpd: Fix code path that leads to uninitialized variables

Donald Sharp sha...@cumulusnetworks.com:
  lib: Add ability to use poll() instead of select

Donald Sharp sha...@cumulusnetworks.com:
  lib: Refactor thread_process_fd

Donald Sharp sha...@cumulusnetworks.com:
  lib: Refactor read/write functionality

Donald Sharp sha...@cumulusnetworks.com:
  lib: Abstract fd set operations

David Lamparter equi...@opensourcerouting.org:
  lib: fix MIN/MAX macros to not double-eval

Donald Sharp sha...@cumulusnetworks.com:
  *: Consolidate all double VIEW_NODE and ENABLE_NODE's

Donald Sharp sha...@cumulusnetworks.com:
  lib: Consolidate VIEW_NODE to be ENABLE_NODE as well

Denil Vira de...@cumulusnetworks.com:
  lib: Replace lists with arrays to store read and write threads

Donald Sharp sha...@cumulusnetworks.com:
  vtysh: Add ability to only look at one processes work queue

David Lamparter equi...@opensourcerouting.org:
  *: get rid of "MTYPE 0"

kitty khiruthigai.balasubraman...@hpe.com:
  ospfd: fix non-zero metric when describing loopback addresses

David Lamparter equi...@opensourcerouting.org:
  build/pimd: remove special shell scripts

David Lamparter equi...@opensourcerouting.org:
  isisd: fix assert warning

Udaya Shankara KS shankara.k....@gmail.com:
  zebra: Enable fpm module to connect to remote fpm server

Donald Sharp sha...@cumulusnetworks.com:
  config: Remove unused library check

Donald Sharp sha...@cumulusnetworks.com:
  bgpd: Removed unused variable from 'struct attr_extra'

Donald Sharp sha...@cumulusnetworks.com:
  bgpd, ripngd, zebra: Remove duplicate PSIZE define

Donald Sharp sha...@cumulusnetworks.com:
  bgpd: Fix 'show bgp ipv4 vpnv4 statistics' cli.

Donald Sharp sha...@cumulusnetworks.com:
  lib: Allow zclient do-over of connect on initial attempt

Balaji balaji...@gmail.com:
  bgpd: Addition of bgp dampening configuration commands under IPv4/multicast

Balaji balaji...@gmail.com:
  bgpd: Addition of dampening show commands under v4 unicast/multicast tree

Matthieu Boutier bout...@pps.univ-paris-diderot.fr:
  lib: Make distribute.c accepts both v4 and v6.

Matthieu Boutier bout...@pps.univ-paris-diderot.fr:
  ripngd: code simplification for redistribution.

Matthieu Boutier bout...@pps.univ-paris-diderot.fr:
  ripd: code simplification for redistribution.

Matthieu Boutier bout...@pps.univ-paris-diderot.fr:
  lib: simplify distribute.c's code.

Boian Bonev bbo...@ipacct.com:
  bgpd: add aspath_aggregate_mpath that preserves path length

Roman Hoog Antink r...@open.ch:
  bgpd: implement admin distance

Roman Hoog Antink r...@open.ch:
  ospf6d: implement admin distance

boris yakubov borisyaku...@ruggedcom.com:
  isisd: Segmentation fault on isis daemon fixes

Christian Franke ch...@opensourcerouting.org:
  lib: update Solaris multicast API (BZ#725)

Paul Jakma p...@jakma.org:
  ripd: split-horizon default differed between rip_interface_new and _reset

Lou Berger lber...@labn.net:
  lib: change command logging to be off by default

林守磊 linxiu...@gmail.com:
  zebra: perfect cmd table

Donald Sharp sha...@cumulusnetworks.com:
  bgpd, lib: Remove RESTRICTED_NODE from code base

Donald Sharp sha...@cumulusnetworks.com:
  zebra: Remove unused #ifdef HAVE_STRUCT_SOCKADDR_DL

Avneesh Sachdev avne...@sproute.com:
  vtysh: support for invoking functions by name

Paul Jakma paul.ja...@hpe.com:
  tests: Update aspath_test.c to exercise remove-private-as

Daniel Walton dwal...@cumulusnetworks.com:
  bgpd: Add replace-as option to remove-private-as

regards,
--
Paul Jakma | p...@jakma.org | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
The trouble with being poor is that it takes up all your time._______________________________________________
Quagga-dev mailing list
Quagga-dev@lists.quagga.net
https://lists.quagga.net/mailman/listinfo/quagga-dev