Baruch, I see this patch labeled as 1 of 2, but can't see the 2nd part (and my CI system is ignoring it while waiting for the 2nd part.
Can you resend (both parts, preferrably labeled as v2) ? Thanks, Martin Winter On Sat, Aug 20, 2016 at 11:23 PM, Baruch Siach <[email protected]> wrote: > From: Thomas Petazzoni <[email protected]> > > When static linking is used, the order of the libraries is important, > and the libraries using a symbol from another library should be listed > *before* the library providing that symbol (see > http://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking) > for details. > > When vtysh is linked statically, the command line contains "-lcurses > -lreadline", which causes a build failure due to unresolved > symbols. This is because readline is using symbols from the curses > library: the order should be the opposite. > > This patch fixes that problem by putting the -lreadline at the > beginning of the LIBREADLINE variable calcualted by the configure > script. > > Signed-off-by: Thomas Petazzoni <[email protected]> > Signed-off-by: Baruch Siach <[email protected]> > --- > configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 6206510855c5..5cf7997a7745 100755 > --- a/configure.ac > +++ b/configure.ac > @@ -643,7 +643,7 @@ dnl [TODO] on Linux, and in [TODO] on Solaris. > )] > )] > ) > - AC_CHECK_LIB(readline, main, LIBREADLINE="$LIBREADLINE > -lreadline",, > + AC_CHECK_LIB(readline, main, LIBREADLINE="-lreadline > $LIBREADLINE",, > "$LIBREADLINE") > if test $ac_cv_lib_readline_main = no; then > AC_MSG_ERROR([vtysh needs libreadline but was not found and > usable on your system.]) > -- > 2.8.1 > > > _______________________________________________ > Quagga-dev mailing list > [email protected] > https://lists.quagga.net/mailman/listinfo/quagga-dev >
_______________________________________________ Quagga-dev mailing list [email protected] https://lists.quagga.net/mailman/listinfo/quagga-dev
