On Wed, 7 Sep 2016, Lou Berger wrote:
On 9/7/2016 6:53 AM, Paul Jakma wrote:
On Tue, 6 Sep 2016, Paul Jakma wrote:
I have another patch that makes valgrind clean for me on the bncs, but
I left the bncs in place while the peer is defined. See patch posted
just there.
Ok, my variation on your fix (hope you don't mind me re-doing that
not at all.
- I
noted what the leak was from your patch,
humm, don't think this is right as all our patches are run against
valgrind prior to submitting.
Hmm, some confusion in wording there. The (minimal) leak was in NHT, and
your fix told me where that the leak was. I.e. yours was the fix to the
leak, not the leak. :) As per the subject.
Now, it does look like this came from an integration problem as we
added the AFI and someone else added the new per afi processing.
Ah, that's a different one.
As both sets of patches were sitting in the patch list the current
process has the integrator (release master) needing to find / fix
these.
That's the other leak? Maybe that was me mis-merging things then, sorry.
This would be both more scalable and efficient as a single integrators
(release master) doesn't need to learn all the changes/interactions.
Of course, minimising the possibility for parallel heads in the future
would help minimise these kinds of problems.
I'll be happy to resubmit (including pull request) our outstanding
patches against the dev/automerge branch once /8 is done to ensure it
integrates cleanly and passes martin's tests.
This is great. I'll run our basic ~15 minute regression with valgrind
against it and let you know the results.
Great, thanks.
There's also a security fix for MRT dumps to go on. An old one, but it
got lost somehow.
regards,
--
Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
Bumper sticker:
All the parts falling off this car are of the very finest
British manufacture.
_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev
