On Thu, 12 Jan 2017, Timo Teras wrote:

Seems to be caused by the recent kernel commit:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1fe8e0f074c77aa41aaa579345a9e675acbebfa9

It is known issue that some of the c-library and kernel header files conflict with each other. Slightly sad, that it's getting more overlap.

Ah, oh dear.

Fundamentally, it would be good to get lib/quagga.h to not include all known headers in the universe. This would allow to include quagga library headers in connection with kernel headers.

Agreed.

Beyond that, a larger cleanup of the exported APIs of header files. It'd be good to define a stable subset, and export it properly under a "quagga/" include namespace.

Probably the simples fix is to split the netlink.c in two parts. I can
send a v3 nhrpd commit, unless you prefer a follow up commit that fixes
it?

Whatever is easier for you. If you have a follow up and want to just send that, that's fine.

regards,
--
Paul Jakma | [email protected] | @pjakma | Key ID: 0xD86BF79464A2FF6A
Fortune:
Fear and loathing, my man, fear and loathing.
                -- H.S. Thompson

_______________________________________________
Quagga-dev mailing list
[email protected]
https://lists.quagga.net/mailman/listinfo/quagga-dev

Reply via email to