It's probably good to clean these things up. In reality the unused imports don't really impact much because nearly all of the modules are already loaded in sys.modules.
My biggest issue is the way he's gone about it. There's no corresponding bug, all the changes are interdependent and I'd rather the flakes cleanup be grouped by functional area of the code (i.e. cisco, db dhcp agent, nec, ovs etc) vs 1 per file. mark On Sep 8, 2012, at 10:39 AM, Gary Kotton <[email protected]> wrote: > Hi, > Over the last few days a number of these fixes were proposed. I have checked > and give my +2. In retrospect I am not really sure what our current mode > should be regarding changes to the code. Should we add things like this or > only make changes that are really necessary? > Thanks > Gary > > -- > Mailing list: https://launchpad.net/~quantum-core > Post to : [email protected] > Unsubscribe : https://launchpad.net/~quantum-core > More help : https://help.launchpad.net/ListHelp -- Mailing list: https://launchpad.net/~quantum-core Post to : [email protected] Unsubscribe : https://launchpad.net/~quantum-core More help : https://help.launchpad.net/ListHelp
