On 01/28/2013 02:26 PM, Akihiro MOTOKI wrote:
Hi Gary, Paul,
Date: Mon, 28 Jan 2013 13:57:35 +0200
From: Gary Kotton<[email protected]>
Subject: Re: [Quantum-core] https://review.openstack.org/#/c/19649/
On 01/28/2013 01:55 PM, Paul Michali wrote:
On Jan 28, 2013, at 2:20 AM, Gary Kotton wrote:
Hi,
It has come to my attention (and not sure how I missed it), that the
aforementioned patch does not actually solve the issue. There are two problems
here:
1. The validation should be done on the quantum service
2. The agents do not require the quantum core plugin - this is only for the
service.
PCM: It ended up being pretty convoluted, as we went round and round on
solutions…
I thought that the agents did not operate correctly, if the core_plugin config
item was not specified? I'll try to double check.
The agent does not require the plugin variable. The plugin is actually
only loaded by the service.
Let me clarify the situation.
Actually most plugin agents require their own plugin specific config files too.
(I'm not sure it can be said to all plugin agent.)
At now the plugin specific config file is referred to by both the plugin
and the plugin agent. For example, OVS agent read its configs from ovs.ini.
Thus to make sure required --config-file options are passed, we need to
check --config-file options both of the service and the agent.
On the other hand, the patch reverted is not a right solution
from the next two points of view:
(1) The plugin agent does not require 'core_pluign' config variable.
It requires just their config variables.
(2) The bug https://bugs.launchpad.net/quantum/+bug/1059923
reports a issue that the quantum service does not create the database
tables. As the commit message said it fixes the bug but it does not fix it,
the solution is not right.
Generally speaking, more strict option validation like what Paul proposed
is a good direction I believe for both the server side and the agent side.
I agree with the strict validations. I do not think that we should
perform validations in a agent that does not use the specific variable.
Say for example we have a multi node Quantum installation. I would not
expect on each node that the user updates the core_plugin variable as
this is not used by the agents.
Thanks,
Akihiro
For the server, it already displays the config settings applied, and checks
that the core_plugin is specified. I could not identify an agent plugin config
to check, as there are default values applied (e.g. sql_connection has SQL
lite) and I couldn't tell if the default was valid or not.
In any case, let me know what I need to do on this bug and on the commit.
Dan has done a rollback.
Thanks
Gary
Regards,
PCM
Sorry for the mess. How can we revert the patch?
Thanks
Gary
--
Mailing list: https://launchpad.net/~quantum-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~quantum-core
More help : https://help.launchpad.net/ListHelp
--
Mailing list: https://launchpad.net/~quantum-core
Post to : [email protected]
Unsubscribe : https://launchpad.net/~quantum-core
More help : https://help.launchpad.net/ListHelp
