It's worth noting that tearDown can fail if an error occurs in setUp. For this reason, it's much preferable to use unittest2/testtools addCleanup() facility, since functions registered this way will be called even if an exception occurs in setUp.
Reference: http://docs.python.org/2/library/unittest.html#unittest.TestCase.addCleanup Thanks, Maru On 2013-02-06, at 11:52 AM, Dan Wendlandt <d...@nicira.com> wrote: > yeah, when these issues happen, its almost always that one plugin (bigswitch > in this case) modified global state, but forgot to restore it. Usually there > is a model where you save any state you muck with in setUp(), modify it > during tests, and restore it in tearDown() > > dan > > On Wed, Feb 6, 2013 at 11:13 AM, Nachi Ueno <na...@nttmcl.com> wrote: > Hi Sumit > I have commented on review comment > https://review.openstack.org/#/c/21285/ > > I faced same problem. it was because of I haven't have teardown method > for cleanup global variable. > > Thanks > Nachi > > 2013/2/6 Sumit Naiksatam <sumitnaiksa...@gmail.com>: > > I am not sure what's happening here in Jenkins. When the following > > Linux Bridge Plugin test is run, it seems to be loading the BigSwitch > > plugin: > > > > ft26.1: > > quantum.tests.unit.linuxbridge.test_lb_db.NetworkBindingsTest.test_add_network_bindingTraceback > > (most recent call last): > > File > > "/home/jenkins/workspace/gate-quantum-python26/.tox/py26/lib/python2.6/site-packages/unittest2/case.py", > > line 340, in run > > testMethod() > > File > > "/home/jenkins/workspace/gate-quantum-python26/quantum/tests/unit/linuxbridge/test_lb_db.py", > > line 154, in test_add_network_binding > > with self.network() as network: > > File "/usr/lib/python2.6/contextlib.py", line 16, in __enter__ > > return self.gen.next() > > File > > "/home/jenkins/workspace/gate-quantum-python26/quantum/tests/unit/test_db_plugin.py", > > line 449, in network > > admin_status_up, **kwargs) > > File > > "/home/jenkins/workspace/gate-quantum-python26/quantum/tests/unit/test_db_plugin.py", > > line 332, in _make_network > > raise webob.exc.HTTPClientError(code=res.status_int) > > HTTPClientError: The server could not comply with the request since it > > is either malformed or otherwise incorrect. > > -------------------- >> begin captured logging << -------------------- > > quantum.manager: DEBUG: Plugin location: > > quantum.plugins.bigswitch.plugin.QuantumRestProxyV2 > > quantum.manager: INFO: Loading Plugin: > > quantum.plugins.bigswitch.plugin.QuantumRestProxyV2 > > .... > > > > And then I am seeing a bunch of errors in the other plugins' tests as > > well, but there is no common code I have touched in this patch. > > > > Thanks, > > ~Sumit. > > > > > > On Wed, Feb 6, 2013 at 4:36 AM, Gary Kotton <gkot...@redhat.com> wrote: > >> Hi, > >> My bad. The tests look OK. > >> Thanks > >> Gary > >> > >> On 02/06/2013 11:18 AM, Gary Kotton wrote: > >>> > >>> Hi, > >>> I am not sure. I know that I am working on a simple bug fix at the moment > >>> and there are a ton of print outs when the test cases run. This seems to > >>> be > >>> related to the latest openstack oslo updates. In the past the logging was > >>> contained in the config module and this was moved out. > >>> Day to day maintenance is becoming more and more challenging. I will try > >>> and take a look and let you know if I see anything. > >>> Thanks > >>> Gary > >>> > >>> > >>> On 02/06/2013 09:26 AM, Sumit Naiksatam wrote: > >>>> > >>>> Hi, > >>>> > >>>> I posted a patch (https://review.openstack.org/#/c/21285) few hours > >>>> back and I am repeatedly seeing a bunch of tests failing outside of my > >>>> patch: > >>>> > >>>> > >>>> http://logs.openstack.org/21285/2/check/gate-quantum-python26/4032/nose_results.html.gz > >>>> > >>>> I noticed Jenkins fail on some other patches too. Just wondering if > >>>> this is an issue with my patch or there is something else amiss. > >>>> > >>>> Thanks, > >>>> ~Sumit. > >>>> > >>> > >>> > >> > >> > >> -- > >> Mailing list: https://launchpad.net/~quantum-core > >> Post to : quantum-core@lists.launchpad.net > >> Unsubscribe : https://launchpad.net/~quantum-core > >> More help : https://help.launchpad.net/ListHelp > > -- > Mailing list: https://launchpad.net/~quantum-core > Post to : quantum-core@lists.launchpad.net > Unsubscribe : https://launchpad.net/~quantum-core > More help : https://help.launchpad.net/ListHelp > > > > -- > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > Dan Wendlandt > Nicira, Inc: www.nicira.com > twitter: danwendlandt > ~~~~~~~~~~~~~~~~~~~~~~~~~~~ > -- > Mailing list: https://launchpad.net/~quantum-core > Post to : quantum-core@lists.launchpad.net > Unsubscribe : https://launchpad.net/~quantum-core > More help : https://help.launchpad.net/ListHelp
-- Mailing list: https://launchpad.net/~quantum-core Post to : quantum-core@lists.launchpad.net Unsubscribe : https://launchpad.net/~quantum-core More help : https://help.launchpad.net/ListHelp
