-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Thu, Nov 03, 2016 at 12:31:58AM -0000, [email protected] wrote: > I find the qvm-ls utility to be quite handy, but often I only want > information about currently running VMs, rather than all of them. > > So I added a -r (--running) flag to do just that (and removed an error > check for zero machines being listed, which is valid with -r). > > This is the first patch I've submitted with git, I hope I'm doing this right: > > https://github.com/JohnyJukya/qubes-core-admin/commit/a2e2c43d0dff96731a85cfd38eecfe851801be95
I've added some comment there. But generally looks fine, and useful! > I have a more substantial contribution I'm working on (a live, graphical > VM memory monitor utility for dom0), but thought I'd submit this smaller > patch first to get my feet with with the process. Generally all is ok. For reference, here is info: https://www.qubes-os.org/doc/source-code/#how-to-send-patches In the future, in addition to pushing to github, you can open pull request there. This will ease review process and track it progress. In addition to that, especially for bigger changes, it's a good idea to send a message here (just like you've just done), to reach people not monitoring github. - -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJYG4BTAAoJENuP0xzK19csTKEH/18yMxICbCNX3SYnmvqu26+Z ek5aBzMgninzjJOOtlGmrBzEejQfnUyNY9k8490v69LKTZ2atcM0LAbZYpi4XB2I lFC6HX231BibEGpL8nWNTiwW61Vw7fgA9F5a4Nd2CO/BR0sl06HcQPTAyq8oc5gs i2ebfaZ51camB2B/ZHH4Q0kfrW2YMPskzGl0kEhS5hD2DlClDbkzAjw9xa7GhTkP w9TWkQgiYMAqtDhlpRyX7G1Bm6cXCwNjj8GpRY+OQ5ALvhEb1T0sazWuhWPhCmtU 2288Pz88Dffm8rbYv/ixAq4h6r4amp6uihlp43f+svJc+au3aM/Z1kILsSdWy3Y= =dpnR -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/20161103182208.GV7073%40mail-itl. For more options, visit https://groups.google.com/d/optout.
