On Sat, 24 Dec 2016, Marek Marczykowski-Górecki wrote: > > > But don't worry - the tricky part (gui-daemon) is the same in > > > R3.2 and R4.0, so testing it on R3.2 is ok. core-admin code is very > > > different, but the patch is easy to apply manually there. And actually > > > I'd reduce code duplication there - to have shm.id path constructed in > > > one place, not three. > > > > Indeed, that would be much cleaner approach. I'll add that change to > > the second version of the changeset. > > > > > And one more thing: please sign your code. Details: > > > https://www.qubes-os.org/doc/code-signing/ > > > > Ok, I'll try (no prior experience gpg usage with email). > > If you like, you can also push git repository somewhere (github or > else), with signed commits and/or signed tag at the top.
The updated changes are now in git repos (hopefully I got signed commits to work properly): https://www.cs.helsinki.fi/u/ijjarvin/qubes/gui-daemon/ https://www.cs.helsinki.fi/u/ijjarvin/qubes/core-admin/ There are two branches in both repositories: release3.2 is what I used for testing in R3.2 and a master compatible one. I did slight improvements to the cmdline parser (and tested it with various valid and invalid inputs using external wrapper tool). As discussed earlier, the release3.2 is not intented to be included to the stable version but just to indicate what was actually tested and for the benefit of those who would might want to use them themselves already in R3.2. In the master branch the changes are untested but for gui-daemon it was just a simple cherrypick and after handling first the code duplication like you suggested, also core-admin changes became much easier to compare between release3.2 and master branches. Thus, I hopefully got the master versions right too so you can simply pull them (rather than resort to handcrafted modifications). -- i. -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/alpine.DEB.2.10.1701081537210.21884%40melkinpaasi.cs.helsinki.fi. For more options, visit https://groups.google.com/d/optout.
