Am Montag, 13. März 2017 08:02:58 UTC+1 schrieb Vít Šesták: > > 1. I generally don't like patterns like this: > > a = transform(a) > > You reuse one variable name for multiple purposes and this makes reading > the code harder. >
point is i don't leave the object around. i like that pattern. anyway, this is a POC, no more, no less. once someone likes it she should reimplement it in C. > > 2. You use JSON as data exchange format. JSON parsing can be viewed as > needlessly complex. One might argue the risks are not so high in most > scenarios, but I don't feel it to be “the Qubes way” there. > again: a POC, for faster implementation i choose JSON. > > 3. You identify files by inode numbers. When I guess inode number, what > prevents me from escaping from my root directory? > yes, that is a know thing and as far as i remember i even mention that myself. > > 4. How is directory traversal prevented? > you can't escape as far as i know. if you find out how it's a bug which must be fixed. > > Note that I've taken rather a brief look, it was not a deep review. > sure. thank you for that. i threw that in as a usability enhancement. just to play around with such a feature. many other solutions come to mind when it comes to inter vm file exchange. this was just one that i implemented to see how that "feels" and if transport via that queue is fast enough. my presonal outcome is: i like it and it's fast enough. next steps would be reimplemantation, security review, gui integration. -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/2eb71513-97f0-466a-a321-5dc557397014%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
