Hello,
There are some events with specific names after a colon, e.g.:
- device-pre-attach:block
- device-list-attached:pci
- property-set:netvm
etc.
and sometimes the same names show up both with and without colons, e.g.:
in core-admin/qubes/vm/__init__.py:
self.vm.fire_event('domain-feature-delete', feature=key)
self.vm.fire_event('domain-feature-set', feature=key, value=value,
self.vm.fire_event('domain-feature-set', feature=key, value=value)
in desktop-linux-common/qubesappmenusext/__init__.py:
@qubes.ext.handler('domain-feature-set:internal')
I think this specific with/without colons mismatch is a bug, but
perhaps the original intention was that two events would be fired, one
foo-bar:specific and one foo-bar, as a means of pre-filtering which
events you care about? I could see this being useful for e.g.
listening on generic property-setting for all properties, but idk.
Also, I wonder if perhaps event identifiers might be better as classes
instead of strings so that we can statically catch event name
mismatches at compile time instead of silently firing or listening for
a typo (or other oversight) which goes nowhere / never comes.
Regards,
Jean-Philippe
P.S.: more documentation for qubes-core-* would be awesome
--
You received this message because you are subscribed to the Google Groups
"qubes-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/qubes-devel/CABQWM_BFA-3bSnuD8q%3Dp34EL-57MrDtpY6TijxfamT0wGW4TnA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
