On Monday, 22 January 2018 16:25:31 CET Marek Marczykowski-Górecki wrote: > > So, my question is if this can still be made consistent, which would > > make my app using the API simpler. > Well, it's a bit late... But I think the benefits may still worth changing > it right now.
I guess it depends on weather the latest RC will be the final or not :) > The alternative is to keep the old behaviour, then add a > new call like admin.vm.ShutdownAndWait (see below about compat). I'm > slightly in favor of the latter option, to not risk breaking things just > before release. But if you think it still worth changing it for > admin.vm.Shutdown, and could help adjusting existing clients, I think we > can do it. I am not in a position to understand the amount of users of the API, just the qvm-shutdown and the qubes-manager as far as I can tell. I'll obviously take care of my qubes-controller project. As python is my least favourite language to program in, I have very little experience with it and have absolutely no idea how to do threading / blocking apis etc. using python. So I'm not sure I can be of much help, and I try to keep my Qubes hacking confined to weekends only :) It would be great if anyone else can help out making this API consistent. As an alternative, adding an 'waitForFinished' argument added to admin.vm.Shutdown may allow the current API to be updated without introducing a new top-level command. Thinking further along those lines; it should be rather trivial to pass 'waitForFinished\0false' in each of the using APIs allowing the default value of that optional argument to be set to 'true' even in the upcoming release. -- Tom Zander Blog: https://zander.github.io Vlog: https://vimeo.com/channels/tomscryptochannel -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/3993802.MHHxty0t7m%40mail. For more options, visit https://groups.google.com/d/optout.
