-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On Fri, Jul 03, 2020 at 06:16:44PM +0000, WillyPillow wrote: > On Friday, July 3, 2020 5:28 AM, Marek Marczykowski-Górecki > <[email protected]> wrote: > > Besides comments I've left there, overall looks good. > > I'm not sure if splitting epoch, version and release into separate > > fields makes much sense - qvm-template would treat all three together as > > a "version" anyway. But it shouldn't hurt either. > > Currently qvm-template does handle version and release separately. (Though > I'll > have to include the epoch later.) The reason I did this is because AFAIK, > comparing RPM versions is not exactly trivial [^rpm], and storing them > separately allows me to use `rpm.labelCompare` to do the job. > > [^rpm]: > <https://blog.jasonantman.com/2014/07/how-yum-and-rpm-compare-versions/>
Ok. > Also, after an initial version of repo handling is finished, should I put > `qvm-template` in `qubesadmin/tools` or somewhere else? Yes, that's exactly where the tool should land. - -- Best Regards, Marek Marczykowski-Górecki Invisible Things Lab A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAl7/iesACgkQ24/THMrX 1yy5fQf9ETJ8FQM43NwAZh3nys5Vz81Edxj6czHZTnRwJOqvlITJTqP5MoyCYbnE A6yI0X+E/5TOy9bftzoiOTiL3BETCjAYm3kPX1qlxD8PQuj+PmBlpwvQLSC6Bz/c 6sHMGKgW8+nQF+yglNqZm9l1NznhK7QWpsq5/eNMSgZPzEtb2Rzez2LlDBgXXbxZ RkS5SDnyViAdP2XxDOGKjy5hx1tpzWCf0knUryKZkU42pBMhRQkQPaOCY3s12w/f Z3k+eV2sLWX43zatd8jTcI9F8oPkTIa4m99D5Yq7FH5sGfq11gtyhGK4K5HZwi2/ LMw6yCBj1u5aee/PrchGnM0YQMEBiA== =PfKb -----END PGP SIGNATURE----- -- You received this message because you are subscribed to the Google Groups "qubes-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/qubes-devel/20200703194131.GE102503%40mail-itl.
