Hi, Le 2/13/22 à 10:05, Holger Levsen a écrit :
On Sat, Feb 12, 2022 at 01:03:35PM +0100, David Hobach wrote:just stumbled across it and was wondering what a reviewer would expect from this code to do:[...]At least on my amchine it executes "badCode" in both domU and dom0.I might miss where you stumbled upon this, but how is this related to qubes? (and why should this code run differently in domU and dom0?)
Holger, you are right, I don't see at all how it related to Qubes OS as it
looks like simply to be a BASH coding issue.
David, As Brendan said, a spell checker like ShellCheck would have spot it to
you. I've just copy pasted your piece of code and:
```
$ shellcheck badcode.sh
In badcode.sh line 14:
foo="$(testCode)" || {echo "foo";}
^-- SC1054: You need a space after the '{'.
For more information:
https://www.shellcheck.net/wiki/SC1054 -- You need a space after the '{'.
```
I personally like BASH very much but it can be exhausting sometimes. I admit it
without any shame and I don't hesitate to massively use ShellCheck to help me
in spotting coding errors I could make or even learn new things sometimes :).
Best,
Frédéric
--
You received this message because you are subscribed to the Google Groups
"qubes-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/qubes-devel/fcc5f239-4ada-18e5-6d90-16fe635793bb%40qubes-os.org.
OpenPGP_signature
Description: OpenPGP digital signature
