BTW, I found something while watching journal:
This line:
echo 1 >"/proc/sys/net/ipv6/conf/${vif}/proxy_ndp"
always results in an error messages in journal upon removal of the vif
(removing netvm from the qube in dom0). It doesn't seem to cause any
observable issue, however it would be good to have some check to avoid
false alarms in logs. Or, if it is safe, adding a " || true" at the end
works too.
Also, shellcheck shows 2 warnings about unused variables.
There are some other possible improvements about the code as a whole,
e.g. "${variable}" is better than "$varible", conditional blocks and
loops are quite lengthy, etc. So, some refactoring might be a good
idea. I am not touching that, just saying, as I have no idea how and
when this was created.
--
You received this message because you are subscribed to the Google Groups
"qubes-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to qubes-devel+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/qubes-devel/20240523182123.28c96814%40localhost.
