Author: david
Date: Tue Jul 26 13:59:38 2011
New Revision: 9383

Log:
Optimization; do least expensive test first

Modified:
   trunk/lib/model/QubitDigitalObject.php

Modified: trunk/lib/model/QubitDigitalObject.php
==============================================================================
--- trunk/lib/model/QubitDigitalObject.php      Tue Jul 26 13:58:35 2011        
(r9382)
+++ trunk/lib/model/QubitDigitalObject.php      Tue Jul 26 13:59:38 2011        
(r9383)
@@ -414,7 +414,7 @@
     }
 
     // Fail if "thumbnail" is not an image
-    if (!QubitDigitalObject::isImageFile($asset->getName()) && 
QubitTerm::THUMBNAIL_ID == $this->usageId)
+    if (QubitTerm::THUMBNAIL_ID == $this->usageId && 
!QubitDigitalObject::isImageFile($asset->getName()))
     {
       throw new sfException('Thumbnail must be valid image type (jpeg, png, 
gif)');
     }

-- 
You received this message because you are subscribed to the Google Groups 
"Qubit Toolkit Commits" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/qubit-commits?hl=en.

Reply via email to