Author: sevein
Date: Fri Aug  5 17:00:11 2011
New Revision: 9443

Log:
Cleanups, PHP 5.3 is mandatory now

Modified:
   
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/pluginsSuccess.php
   
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/themesSuccess.php

Modified: 
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/pluginsSuccess.php
==============================================================================
--- 
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/pluginsSuccess.php
  Fri Aug  5 16:54:32 2011        (r9442)
+++ 
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/pluginsSuccess.php
  Fri Aug  5 17:00:11 2011        (r9443)
@@ -8,40 +8,29 @@
     <thead>
       <tr>
         <th>
-          Name
+          <?php echo __('Name') ?>
         </th><th>
-          Version
+          <?php echo __('Version') ?>
         </th><th>
-          Enabled
+          <?php echo __('Enabled') ?>
         </th>
       </tr>
     </thead><tbody>
       <?php foreach ($plugins as $name => $plugin): ?>
         <tr class="<?php echo 0 == ++$row % 2 ? 'even' : 'odd' ?>">
-
           <td>
-
             <?php if (file_exists($plugin->getRootDir().'/images/image.png')): 
?>
               <?php echo image_tag('/plugins/'.$name.'/images/image', 
array('alt' => $name)) ?>
             <?php endif; ?>
-
             <h2><?php echo $name ?></h2>
-
             <div class="description">
-              <?php $class = new ReflectionClass($plugin); echo 
$class->getStaticPropertyValue('summary') // HACK Use $plugin::$summary in PHP 
5.3 http://php.net/oop5.late-static-bindings ?>
+              <?php echo $plugin::$summary ?>
             </div>
-
-          </td>
-
-          <td>
-            <?php echo $class->getStaticPropertyValue('version') // HACK Use 
$plugin::$version in PHP 5.3 ?>
-          </td>
-
-          <?php // TODO Should redisplay tainted value ?>
-          <td align="center">
+          </td><td>
+            <?php echo $plugin::$version ?>
+          </td><td align="center">
             <input<?php if ($form->isBound() && in_array($name, 
$form->getValue('enabled')) || !$form->isBound() && in_array($name, 
$form->getDefault('enabled'))): ?> checked="checked"<?php endif; ?> 
name="enabled[]" type="checkbox" value="<?php echo $name ?>"
           </td>
-
         </tr>
       <?php endforeach; ?>
     </tbody>

Modified: 
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/themesSuccess.php
==============================================================================
--- 
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/themesSuccess.php
   Fri Aug  5 16:54:32 2011        (r9442)
+++ 
trunk/plugins/sfPluginAdminPlugin/modules/sfPluginAdminPlugin/templates/themesSuccess.php
   Fri Aug  5 17:00:11 2011        (r9443)
@@ -8,40 +8,29 @@
     <thead>
       <tr>
         <th>
-          Name
+          <?php echo __('Name') ?>
         </th><th>
-          Version
+          <?php echo __('Version') ?>
         </th><th>
-          Enabled
+          <?php echo __('Enabled') ?>
         </th>
       </tr>
     </thead><tbody>
       <?php foreach ($plugins as $name => $plugin): ?>
         <tr class="<?php echo 0 == ++$row % 2 ? 'even' : 'odd' ?>">
-
           <td>
-
             <?php if (file_exists($plugin->getRootDir().'/images/image.png')): 
?>
               <?php echo image_tag('/plugins/'.$name.'/images/image', 
array('alt' => $name)) ?>
             <?php endif; ?>
-
             <h2><?php echo $name ?></h2>
-
             <div class="description">
-              <?php $class = new ReflectionClass($plugin); echo 
$class->getStaticPropertyValue('summary') // HACK Use $plugin::$summary in PHP 
5.3 http://php.net/oop5.late-static-bindings ?>
+              <?php echo $plugin::$summary ?>
             </div>
-
-          </td>
-
-          <td>
-            <?php echo $class->getStaticPropertyValue('version') // HACK Use 
$plugin::$version in PHP 5.3 ?>
-          </td>
-
-          <?php // TODO Should redisplay tainted value ?>
-          <td align="center">
+          </td><td>
+            <?php echo $plugin::$version ?>
+          </td><td align="center">
             <input<?php if ($form->isBound() && in_array($name, 
$form->getValue('enabled')) || !$form->isBound() && in_array($name, 
$form->getDefault('enabled'))): ?> checked="checked"<?php endif; ?> 
name="enabled[]" type="checkbox" value="<?php echo $name ?>"
           </td>
-
         </tr>
       <?php endforeach; ?>
     </tbody>

-- 
You received this message because you are subscribed to the Google Groups 
"Qubit Toolkit Commits" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/qubit-commits?hl=en.

Reply via email to