Author: david
Date: Thu Jul  5 14:06:41 2012
New Revision: 11859

Log:
Break out PDF representation creation from images. Use switch instead of 
if/else for logic tree.

Modified:
   trunk/lib/model/QubitDigitalObject.php

Modified: trunk/lib/model/QubitDigitalObject.php
==============================================================================
--- trunk/lib/model/QubitDigitalObject.php      Thu Jul  5 13:47:41 2012        
(r11858)
+++ trunk/lib/model/QubitDigitalObject.php      Thu Jul  5 14:06:41 2012        
(r11859)
@@ -929,39 +929,59 @@
    */
   public function createRepresentations($usageId, $connection = null)
   {
-    // Scale images (and pdfs) and create derivatives
-    if ($this->canThumbnail())
+    switch ($this->mediaTypeId)
     {
-      if ($usageId == QubitTerm::EXTERNAL_URI_ID || $usageId == 
QubitTerm::MASTER_ID)
-      {
-        $this->createReferenceImage($connection);
-        $this->createThumbnail($connection);
-      }
-      else if ($usageId == QubitTerm::REFERENCE_ID)
-      {
-        $this->resizeByUsageId(QubitTerm::REFERENCE_ID);
-        $this->createThumbnail($connection);
-      }
-      else if ($usageId == QubitTerm::THUMBNAIL_ID)
-      {
-        $this->resizeByUsageId(QubitTerm::THUMBNAIL_ID);
-      }
-    }
+      case QubitTerm::IMAGE_ID:
+        // Scale images and create derivatives
+        if ($this->canThumbnail())
+        {
+          if ($usageId == QubitTerm::EXTERNAL_URI_ID || $usageId == 
QubitTerm::MASTER_ID)
+          {
+            $this->createReferenceImage($connection);
+            $this->createThumbnail($connection);
+          }
+          else if ($usageId == QubitTerm::REFERENCE_ID)
+          {
+            $this->resizeByUsageId(QubitTerm::REFERENCE_ID);
+            $this->createThumbnail($connection);
+          }
+          else if ($usageId == QubitTerm::THUMBNAIL_ID)
+          {
+            $this->resizeByUsageId(QubitTerm::THUMBNAIL_ID);
+          }
+        }
 
-    if ($this->mediaTypeId == QubitTerm::VIDEO_ID)
-    {
-      if ($usageId == QubitTerm::EXTERNAL_URI_ID || $usageId == 
QubitTerm::MASTER_ID)
-      {
-        $this->createVideoDerivative(QubitTerm::REFERENCE_ID, $connection);
-        $this->createVideoDerivative(QubitTerm::THUMBNAIL_ID, $connection);
-      }
-    }
-    else if ($this->mediaTypeId == QubitTerm::AUDIO_ID)
-    {
-      if ($usageId == QubitTerm::EXTERNAL_URI_ID || $usageId == 
QubitTerm::MASTER_ID)
-      {
-        $this->createAudioDerivative(QubitTerm::REFERENCE_ID, $connection);
-      }
+        break;
+
+      case QubitTerm::TEXT_ID:
+        if ($usageId == QubitTerm::EXTERNAL_URI_ID || $usageId == 
QubitTerm::MASTER_ID)
+        {
+          // Thumbnail PDFs (may add other formats in future)
+          if ($this->canThumbnail())
+          {
+            $this->createReferenceImage($connection);
+            $this->createThumbnail($connection);
+          }
+        }
+
+        break;
+
+      case QubitTerm::VIDEO_ID:
+        if ($usageId == QubitTerm::EXTERNAL_URI_ID || $usageId == 
QubitTerm::MASTER_ID)
+        {
+          $this->createVideoDerivative(QubitTerm::REFERENCE_ID, $connection);
+          $this->createVideoDerivative(QubitTerm::THUMBNAIL_ID, $connection);
+        }
+
+        break;
+
+      case QubitTerm::AUDIO_ID:
+        if ($usageId == QubitTerm::EXTERNAL_URI_ID || $usageId == 
QubitTerm::MASTER_ID)
+        {
+          $this->createAudioDerivative(QubitTerm::REFERENCE_ID, $connection);
+        }
+
+        break;
     }
 
     return $this;

-- 
You received this message because you are subscribed to the Google Groups 
"Qubit Toolkit Commits" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/qubit-commits?hl=en.

Reply via email to