Thanks! On Wed, 25 Nov 2020, 02:12 Ian Swett, <[email protected]> wrote:
> Filed #4408 <https://github.com/quicwg/base-drafts/issues/4408> and PR > #4409 sent out to improve clarity in the best way I can think of. > > On Tue, Nov 24, 2020 at 7:13 PM Lucas Pardue <[email protected]> > wrote: > >> Ian or Jana, >> >> If you believe Timo's comment is valid can you please create an issue? >> >> Cheers >> Lucas >> >> On Tue, Nov 24, 2020 at 6:19 PM Ian Swett <ianswett= >> [email protected]> wrote: >> >>> It's a bit subtle, but the current pseudocode does the right thing, >>> because sent_bytes is only set to a non-0 value in OnPacketSent() if the >>> packet is in_flight: >>> >>> sent_packets[pn_space][packet_number].sent_bytes = >>> sent_bytes >>> >>> Given the way it's used, maybe it makes sense to rename sent_bytes to >>> inflight_bytes? Though that could be confused with byte_in_flight? >>> >>> Ian >>> >>> On Tue, Nov 24, 2020 at 2:09 AM Timo Völker <[email protected]> >>> wrote: >>> >>>> Hi all, >>>> >>>> The pseudo code in the recovery draft uses the function >>>> DetectAndRemoveAckedPackets. Is my assumption correct that this function >>>> should return a list of all newly acked packets (including these that do >>>> not count as in flight)? >>>> >>>> If so, it seems there is a bug in the code, because this list is passed >>>> to the congestion controller, which uses *all* the packets in the list to >>>> decrease its bytes_in_flight. >>>> >>>> Timo >>> >>>
