Hi Karl, Thanks for your email. FYI Tom hasn't been active in the project for some years now so your sending an email to the list is the best approach.
Your manage_comments.pt change does look right if in fact that template is now a browser view rather than a CMF skin template (haven't looked at the code base in a while so don't know). I'll take your word for it on the getTopics change but in principle it sounds fine. Do you have a diff of your changes as I can commit it for you if you like? Thanks, Tim On Mon, 2008-10-20 at 23:48 +0200, Karl Bengtsson wrote: > Hello all, > > This is my first ever attempt at contributing to an open source > project. It is also my first ever time on a mailing list, so I hope > I'm going about things the right way :-) > > About a week ago I email [EMAIL PROTECTED], the adress > listed as maintainer of Quills on http://plone.org/products/quills. I > haven't recieved any replies, so I'm forwarding my email to this list > instead, in the hope that someone reads it here instead. > > Best regards, > > Karl Bengtsson > > ----------------------------------- > Start of forwarded email: > ----------------------------------- > I've noticed a few issues/bugs when deploying Quills via buildout on a > Plone 3.1.* site that I'm currently developing. I've managed to fix > these bugs so that everything works to satisfaction on my site, but I > note that the issues are still unfixed in the Subversion repository at > http://svn.plone.org/svn/collective/quills.app/trunk/ > . So, I figured the nice thing to do in the spirit of open source and > all that would be to send in my little patches to the maintainer, in > the hope that they improve the quality of the product, or somesuch. > > The issues are as follows: > > 1) Topics/keywords with non-unicode or non-ascii characters break the > getImage(self) method in topic.py on line 92. This means that the blog > simply cannot be viewed if such characters are present in any keywords/ > topics that are displayed. The method that breaks is: > > keyword_id = normalizer.normalize(self.keywords[0]) > > The normalize()-method appearently requires a unicode string input, > and self.keywords returns whatever string format the keywords are > entered as. The tag cloud portlet instead uses the self.getTopics() > method which appears to take character sets into consideration, as it > works perfectly with my latin-1 type characters. My suggestion is thus > to change the line that breaks into the following: > > keyword_id = normalizer.normalize(self.getTopics()[0]) > > 2) The manage_comments.pt page template uses the syntax "python > test()", which does not work any more. The syntax is used on line 92 > and 102. According to some googling and searching of the mailing lists > the test() method is deprecated. Instead the proper syntax should be : > > tal:attributes="class python:oddrow and 'even' or 'odd'" (line 92) > > and > > checked python:request.get('ids_checked', False) and 'checked' or > None; (line 102) > _______________________________________________ > quills-dev mailing list > [email protected] > http://lists.etria.com/cgi-bin/mailman/listinfo/quills-dev _______________________________________________ quills-dev mailing list [email protected] http://lists.etria.com/cgi-bin/mailman/listinfo/quills-dev
