On Tue, May 24, 2005 at 01:15:29PM +0200, Jean Delvare wrote: > [Jean Delvare] > > We may want to document the problem in quilt and state that quilt > > requires diffstat >= 1.32 for proper "quilf refresh --diffstat" > > operation. Maybe we could even have ./configure check for the version? > > [Josh Boyer] > > I'd rather not make quilt require the newer diffstat. The garbage may > > be slightly annoying, but quilt doesn't really require the newest. > > Plus, there are lots of users using 1.31 (anyone using Fedora Core 3), > > and I'd rather not break quilt for them. > > Agreed, we shouldn't require a recent version. However, we could have > ./configure emit a warning if an old version is found. A patch > attempting to do that is attached (against quilt 0.40). Disclaimer: this > is my very first attempt at hacking a configure script, so my code may > be suboptimal. Comments are welcome, I am willing to learn ;)
From what I see, you will warn on version 2.01 too. I'd change the test major -lt 1 -o minor -lt 32 to test major -le 1 -a minor -lt 32 or so. > [Josh Boyer] > > Let's just reject the patch for now and I'll work on getting the newer > > diffstat into Fedora Core. > > Having quilt warn on older versions is likely to make distributions more > willing to upgrade to newer versions, and this is one of the reasons why > I think we should have it do so. Fedora is certainly not the only > distribution coming with an old version of diffstat. I've 1.39 in debian (testing), but I'm sure the version in stable is *ancient*. Bye, Mt.
signature.asc
Description: Digital signature
_______________________________________________ Quilt-dev mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/quilt-dev
