Hello, On Friday 08 July 2005 12:27, Peter Williams wrote: > Jean Delvare wrote: > > Hi all, > > > > What about a new release of quilt soon? There have been quite a few > > improvements in CVS recently, it would be great if more people could > > take benefit of these. > > > > Andreas? > > Before you make this release could you please apply the attached patch? > > It adds a "description" which can be used to view and set the > description component of a patch's header. This will enable me to add > mechanisms for adding/viewing patch descriptions to gquilt.
I have a few comments: - I would rather make this the header command. We are usually calling what's above the actual patch the header, no? - I don't see why it's useful or necessary to remove the diffstat part. Any reasons? Presumably... - Instead of patch_description_tail, please reuse the patch_description function from patchfns (which is probably misnamed, and should be called patch_header instead.) - Is removing whitespace in the header really needed? I don't think anybody cares much about whitespace in the header at all; it's annyoing in the actual patch though. - We can easily get rid of the temporary files and use pipes instead. I can easily do that when checking in the final version if you wish. - The command must not touch $patch~refresh. - I see a dangling opt_format variable. - Could you please provide a test case? Cheers, -- Andreas Gruenbacher <[EMAIL PROTECTED]> SUSE Labs, SUSE LINUX PRODUCTS GMBH _______________________________________________ Quilt-dev mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/quilt-dev
