On 1/17/06, Andreas Gruenbacher <[EMAIL PROTECTED]> wrote: > http://zeroj.hda0.net/quilt-0.43-patches-v3/make-check.diff > > A really good idea. > > Some comments: > > - I'd prefer something like test/.$test.ok (dot files).
ok. > - Can we have a check-all target that runs all tests? good idea, > - Can we keep the general dependencies of each test in > Makefile.in instead of moving them to test/.depend, e.g., > > $(wildcard test/*.test) :: bin/quilt quilt/scripts/patchfns i'll try that out. > There are other dependencies between specific commands and scripts, > but maybe we should define them explicitly in Makefile.in? those can be automaticly determined as well using `quilt_command'. I dont think its worth recording these in Makefile.in, as the make process generates them all indescriminately. perhaps these extra deps should be placed in test/.depend for the moment? > - You strip off test/*.test from TESTS and then always glue it on > again? Yes; that makes the list of tests easier to manipulate. One consequence is that `make check-fold' is a valid rule. > - `echo $$test | sed -e 's/\.test/\.ok/'` => we already have this, > it should do: > > test/%.ok :: test/%.test thanks for picking that up. > - Why can't we include test/.depend whenever it's there? as test/.depend is an include that is also a target, make will first verify that it's not stale. this is a performance hit for `default' and 'install', and it clutters up make -d. > - Instead of patsubst we can use $(<:test/%=%) etc. nice. -- John _______________________________________________ Quilt-dev mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/quilt-dev
