On Thursday 31 July 2008 11:52:36 Thomas Petazzoni wrote:
> Hi,
>
> I recently discovered that quilt might generate invalid Message-Id when
> giving quilt an invalid --sender value.
>
> I was using
>
> --sender "Thomas Petazzoni <[EMAIL PROTECTED]>"
>
> and quilt generated Message-Id like:
>
> Message-Id: <[EMAIL PROTECTED]>>
>
> Note the two '>' at the end. Because of that, the mails get rejected by
> mailing list filters, notably on vger.kernel.org.
>
> Maybe quilt should check whether the provided sender value is sane
> enough to not generate an invalid Message-Id ?
This should have been fixed with this commit:
revision 1.30
date: 2007-08-08 12:38:57 +0200; author: agruen; state: Exp; lines: +3 -2;
c
- quilt mail: strip closing angle brackets from the mail sender
address before it is inserted into the message ID. (Changed
by [EMAIL PROTECTED])
Do you have that?
Andreas
Index: quilt/mail.in
===================================================================
RCS file: /sources/quilt/quilt/quilt/mail.in,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- quilt/mail.in 6 May 2007 12:40:06 -0000 1.29
+++ quilt/mail.in 8 Aug 2007 10:38:57 -0000 1.30
@@ -68,7 +68,7 @@
msgid()
{
local timestamp=$(date --utc "+%Y%m%d%H%M%S.%N")
- echo "[EMAIL PROTECTED]@}"
+ echo "[EMAIL PROTECTED]"
}
process_mail()
@@ -88,7 +88,7 @@
| sendmail ${QUILT_SENDMAIL_ARGS--f "$opt_sender"} "$@"
else
local from_date=$(date "+%a %b %e %H:%M:%S %Y")
- echo "From $opt_sender $from_date"
+ echo "From $opt_sender_address $from_date"
sed -e 's/^From />From /' $tmpfile
echo
fi
@@ -192,6 +192,7 @@
;;
esac
fi
+opt_sender_address=$(echo "$opt_sender" | sed -re 's:.*<([^<>]+)>.*:\1:')
if [ -z "$opt_charset" ]; then
case "${LC_ALL:-$ORIGINAL_LANG}" in
_______________________________________________
Quilt-dev mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/quilt-dev
