Hello,
On Sun, Jan 12, 2014 at 12:48:30PM +0100, Jean Delvare wrote:
>
> On Sun, 29 Dec 2013 22:48:01 +0100, Martin Quinson wrote:
> > Description: Exit with an error when diff's retcode=2 (error) on patch
>
> I am just realizing that the description seems to be truncated. I think
> you mean "on patch refresh"?
Erm, it was manually truncated (I did type it wrong) :/
> > Index: b/quilt/scripts/patchfns.in
> > ===================================================================
> > --- a/quilt/scripts/patchfns.in
> > +++ b/quilt/scripts/patchfns.in
> > @@ -766,6 +766,12 @@
>
> Can you please generate your patches with diff option -p in the future?
> I makes reviewing easier.
I need to investigate because it should be the case accordign to my
settings.
> > + $ quilt refresh
> > + > diff: test.txt: Permission denied
> > + > Diff failed on file 'test.txt', aborting.
>
> Please check the return value here:
>
> $ echo %{?}
> > 1
It does not work for me. If I use %{?}, it echoes ?. If I use $? it
echoes 0. And looking at test/run, I don't see where the return value
of the child command should be set into $?. No other test check the
return value of the commands. test/conflicts.test should do that but
doesnt.
> BTW, the return value of "quilt diff" in case a binary file is included
> is still 0. I think it needs to be fixed as well,
Not sure about it actually. quilt diff kinda works on binary, doesn't
it?
Bye, Mt.
--
A theory is falsifiable [(and therefore scientific) only] if the
class of its potential falsifiers is not empty.
-- Sir Karl Popper _The Logic of Scientific Discovery_ ยง21
_______________________________________________
Quilt-dev mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/quilt-dev
