Title: TQI - Technology and Quality on Information
Yes....!!!
Thanks
Vadim
Mauro Sergio Ferreira Brasil wrote:
Hi Vadim!
During the effort to reapply the patch regarding the full handling of
"ptime" media atribute and iLBC's "mode" parameter, I've identified
what seems to be a problem on "ph_astream_encoded_framesize_get" method
calculation.
The problem is that the calculation proposed to acchieve the current
frame size isn't valid for all conditions.
For example: considering that iLBC codec framesize members are
initialized with an encoded value of 38 bytes (for 20ms packetization),
if we start a call that forces the packetization to 30ms (by "mode"
parameter) we'll have method "ph_astream_encoded_framesize_get"
returning 57 for the encoded frame size that is in fact only 50.
This mismatched value leads to a wrong stream recalculation on method
"ph_media_retrieve_decoded_frame".
I would like to suggest that both methods
"ph_astream_decoded_framesize_get" and
"ph_astream_encoded_framesize_get" should use new "phcodec_t" member
methods that, given the current packetization, returns the right
encoded/decoded framesize.
The implementation of these methods will be mandatory only for those
codecs that the calculation performed by now leads to not accurate
results, like iLBC. Most codecs won't need to implement these new
"phcodec_t" member methods, what will result on
"ph_astream_decoded_framesize_get" and
"ph_astream_encoded_framesize_get" methods current execution.
Do you agree with that ?
--
| At.,
|
 |
| Technology
and Quality
on Information |
| Mauro Sérgio
Ferreira Brasil |
| Coordenador
de Projetos e
Analista de Sistemas |
| + mauro.bra...@tqi.com.br |
| : www.tqi.com.br |
| ( + 55 (34)3291-1700 |
| ( + 55 (34)9971-2572 |
|
_______________________________________________
QuteCom-dev mailing list
QuteCom-dev@lists.qutecom.org
http://lists.qutecom.org/mailman/listinfo/qutecom-dev
