Hi Vadim!
Not a problem at all about the delay...
I was expecting you'll take some time for sure, because of your usual
demands and
because this patch, as you've said, is quite BIG... :-)
First of all sorry about the CRLFs.
I develop on Visual Studio and use to migrate the changes to Qutecom
trunk to
generate the patches. That's why it's happening.
I'll try to avoid on next patches.
About this error, I'm pretty shame here.
Visual Studio only indicate this as a warning and I didn't noticed.
Could you please just remove the "payload_id" parameter on the same
instruction as presented below ?
remote_media_pos = sdp_message_get_media_pos(
remote, local_media->m_media, payload_id);
Or do you preffer that I rebuild the entire patch ?
Thanks and best regards,
Mauro.
Vadim Lebedev escreveu:
Hi Mauro,
Sorry for the delay but i've been a little ovelaoded last week... and
your patch is BIG...
I've tride to apply it ot the latest version of Qutecoma and it does
not compile...
Here is the error message
[ 37%] Building C object
wifo/eXosip/CMakeFiles/exosip.dir/src/ow_osip/osip_negotiation.o
/home/vadim/QuteCom/qutecom-2.2-patched/wifo/eXsip/src/ow_osip/osip_negotiation.c:
In function
‘osip_negotiation_execute_media_negotiation’:
/home/vadim/QuteCom/qutecom-2.2-patched/wifo/eXosip/src/ow_osip/osip_negotiation.c:1074:
error: too many arguments to function
‘sdp_message_get_media_pos’
Thanks
Vadim...
P.S. Your files contains CRLFs ... it would be nice igf you could
avoid it...
Mauro Sergio Ferreira Brasil wrote:
Hi Vadim!
I'm getting back to the effort of making this packetization patch work
properly, and I would like to check out some possibilities with you.
The main objective with this message is to list here all changes on
"phcodec_t" structure that I think will be demanded by this patch (the
first one only) and future ones (the other two).
1- On prior messages and on the patch itself I presented a change on
"phcodec_t" structure. A new method responsible for performing the
"media attribute" negotiation was created. Are you ok with that ?
2- Our customer have licenced G.729 codec for use on their Voip client,
and this demands the addition of a "fmtp" media attribute that is, of
course, specific to it. So, I was thinking to add another method to
"phcodec_t" structure that will allow some codec to add related
attributes when building the initial SDP (on method
"eXosip_initiate_call") and when answering to a call (on method
"generating_sdp_answer"). Is that ok too ?
Obs.: Both items above will demand a callback method registration from
"phapi" library (that holds the codecs) to "eXosip" library that is
responsible for SDP negotiation, avoiding dependency from "eXosip" with
"phapi" as requested.
3- Another method will be necessary considering a future patch to
handle a very specific packetization issue, that is: the callee do not
consider the "ptime" indicated on the call. On this scenario, and for
codecs like iLBC that demand packetization initialization, we need a
way to reinitialize the incoming packetization to fit the real frame
size and not the one indicated through "ptime". In fact, this could
have some impact on media buffer allocation that I'm not completely
aware now.
Please let me know whether you preffer to have this structure changes
added to "phcodec_t" structure on a per-patch basis.
What, in fact, will make much sense.
Thanks and best regards,
Mauro.
Vadim Lebedev escreveu:
Mauro,
Apparently i've missed that point earlier, sorry about that.
I can suggest to implement some kind a callback scheme.
Suppose upiu add a callabck pointer to sdp negotiator which
will
resid in pahapi and will call phcodec routines to obtain the info.
Thanks
Vadim
P.S. Btw ilbc codec support is built as plugin and is not
residing anymore in phcodec.c
--
TQI - Technology and Quality on Information
| At.,
|
 |
| Technology
and Quality
on Information |
| Mauro Sérgio
Ferreira Brasil |
| Coordenador
de Projetos e
Analista de Sistemas |
| + [email protected] |
| : www.tqi.com.br |
| ( + 55 (34)3291-1700 |
| ( + 55 (34)9971-2572 |
--
TQI - Technology and Quality on Information
| At.,
|
 |
| Technology and Quality
on Information |
| Mauro Sérgio Ferreira Brasil |
| Coordenador de Projetos e
Analista de Sistemas |
| + [email protected] |
| : www.tqi.com.br |
| ( + 55 (34)3291-1700 |
| ( + 55 (34)9971-2572 |
|
_______________________________________________
QuteCom-dev mailing list
[email protected]
http://lists.qutecom.org/mailman/listinfo/qutecom-dev
