Em Sun, 2012-07-22 às 16:32 +0300, Toni Gundogdu escreveu:
> On Sat, 21 Jul 2012 18:54:12 +0100
> Bastien Nocera <[email protected]> wrote:
> 
> > In addition to the arte and BBC patches I posted to trac, here are a
> > few more bugs fixes.
> >
> > quvi-tool:
> > 0001-Check-for-and-use-gengetopt.patch
> 
> A quote from the commit message:
> > Otherwise it takes ages to figure out how to build quvi-tool from git.
> 
> At the end of the INSTALL file, under "Installation from development
> code", it says:
>   "If you are compiling quvi from the development code, run
>   'autogen.sh', first."
> 
> And:
>   "You will need: GNU gengetopt"

I've never read the INSTALL file, and I don't expect anyone that would
compile libquvi-scripts from git to expect it to contain anything but
standard autotools verbiage.

> When you run the autogen.sh without gengetopt, it should produce an
> error, e.g.:
>   autogen.sh: 77: gengetopt: not found

Make it error out then.

-    -C --unamed-opts=URL --output-dir src/quvi --no-version
+    -C --unamed-opts=URL --output-dir src/quvi --no-version || exit 1

> I think that only developers should be required to install gengetopt.
> The dist tarball contains the cmdline.c file already.
> 
> > libquvi-scripts:
> > 0001-Fix-build-with-NSFW-and-FIXME-scripts-enabled.patch
> 
> Both master and next branches seem to have this fixed already.

Must have been an old patch here.

Cheers


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
quvi-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/quvi-devel

Reply via email to