Thanks, Jeff, good catch. Now committed.
Simon

On Sep 29, 2009, at 18:27 , Jeff Horner wrote:

Simon Urbanek wrote:
[...]
I don't have konqueror at hand, so I have tested and fixed the lynx case (lynx is acting as an HTTP/1.0 client and expects non- persistent connection). With some luck the fix may solve the konqueror issue as well (although I'd be a bit surprised if konqueror was not 1.1-capable..).

Konqueror didn't like the extra newline in the Location header:

Index: src/library/tools/R/dynamicHelp.R
===================================================================
--- src/library/tools/R/dynamicHelp.R   (revision 49890)
+++ src/library/tools/R/dynamicHelp.R   (working copy)
@@ -172,7 +172,7 @@
return(list(payload = paste('Redirect to <a href="', file, '">"',
                        basename(file), '"</a>', sep=''),
                       "content-type" = 'text/html',
- header = paste('Location: ', file, '\n', sep=''),
+                       header = paste('Location: ', file, sep=''),
                       "status code" = 302L)) # temporary redirect
       } else if (length(file) > 1L) {
            paths <- dirname(dirname(file))


Jeff



______________________________________________
R-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/r-devel

Reply via email to