Paul Roebuck <[EMAIL PROTECTED]> writes: > R 2.1.0/src/include from 2005/04/18 download > > Naming inconsistent for guards as well but that's pedantic. > Simple convention: > file <foo.h> > #ifndef R_FOO_H > file <R_ext/bar.h> > #ifndef R_EXT_BAR_H > > Missing guards: > <IOStuff.h> > <Internal.h> > <Parse.h> > <R_ext/GraphicsBase.h> > <R_ext/GraphicsDevice.h> > <R_ext/GraphicsEngine.h> > <R_ext/R-ftp-http.h> > <R_ext/libextern.h> > > > Illegal Guards (leading underscore): > <Rinternals.h> > <R_ext/Error.h> > <config.h.in>
Thanks. The ones outside R_ext, except Rinternals.h, are not part of the API, so it is not a bug that there are no guards - could still be a good idea to have them of course. libextern.h explicitly says that you shouldn't disallow including it more than once. So the ones with real problems would be <R_ext/GraphicsBase.h> <R_ext/GraphicsDevice.h> <R_ext/GraphicsEngine.h> <R_ext/R-ftp-http.h> <Rinternals.h> <R_ext/Error.h> What's illegal about leading underscores, BTW? -- O__ ---- Peter Dalgaard Blegdamsvej 3 c/ /'_ --- Dept. of Biostatistics 2200 Cph. N (*) \(*) -- University of Copenhagen Denmark Ph: (+45) 35327918 ~~~~~~~~~~ - ([EMAIL PROTECTED]) FAX: (+45) 35327907 ______________________________________________ R-devel@stat.math.ethz.ch mailing list https://stat.ethz.ch/mailman/listinfo/r-devel
