On Monday, July 24, 2017 at 11:36:00 PM UTC+2, Daniel Prager wrote: > Hi Zelphir > > Thanks for the attribution. > > I'm running on a MacBook Air, 2012 vintage. > > Why not run both my and your code on your machine and compare? > > I made no optimisations other than assuming binary classification. > > > > Dan > > > On Tue, Jul 25, 2017 at 6:46 AM, Zelphir Kaltstahl <zelphirk...@gmail.com> > wrote: > > > > > With my implementation of a list of vectors I only get down to: > > > > cpu time: 996 real time: 994 gc time: 52 > > > > on my machine. Now I don't know what kind of machine you have, but I guess > with such small data sets it does not matter that much and the list of lists > implementation is faster, at least for low dimensional data :) It seems > vectors involve a bit of overhead or you did some other optimization, which I > still have to add to my code. (Maybe assuming binary class, but that should > not make that much of a difference, I think. Might try that soon.) > > > > I added your code as a new file and added a comment at the top of the file: > > > > #| > > Attribution: > > > > This implementation of decision trees in Racket was written by Daniel Prager > and > > was originally shared at: > > > > https://groups.google.com/forum/#!topic/racket-users/cPuTr8lrXCs > > > > With permission it was added to the project. > > |# > > > > My project on Github is GPLv3.
Your implementation is more complete than mine, I only got around to fixing the things mentioned in this topic, not to implementing all the other stuff still waiting for me in the tutorial. As soon as that is done, I can do a comparison. Another interesting thing would be to see how many more column (if at all) it takes to make vectors the faster implementation. I also need to take a look at some procedures you used in the code, which I am not familiar with yet, but which are standard Racket. There might be clever implementations behind those, which are better than what I would write with the set of things I know about Racket. -- You received this message because you are subscribed to the Google Groups "Racket Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to racket-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
