I too have tried to contribute to the expansion, improvement, and re-integration of facets... twice now
My take is, the Core team isn't ready to seriously review patches and find a solution. They're procrastinating on the problem. I think if I were to try a third time I would simply write a plugin that duplicates all of the code of the current admin interface and then adds the needed 'facets-like' modularity. It's really a hack and not the way it should be done long term, but the power of Ruby makes it possible. Once you write that 'base-facets' plugin and written a bunch of plugins on top of that.. My theory is that you can more easily test the market for your facets-requiring plug-ins. If mainstream users of radiant can benefit from your admin-interface-changing plugin they are more likely to go through the effort of installing it and using it and giving honest useful feedback if they can simply install a set of extensions on their existing radiant installation (as opposed to having to download an old branch) THEN finally the core team will Know what they actually want the 'facets-like' functionality of the core radiant to be and properly address it. Do you see what I'm getting at? No disrespect to the core team, I think they are doing a great job maintaining a solid stable product. But if you want to experiment, build a plugin so everybody can install it onto their existing radiant. Once it's really popular, then the core team will accept your patch to make it possible "The right way". And then I'll be able to port my extensions... : ) On 8/15/07, Sean Cribbs <[EMAIL PROTECTED]> wrote: > > Damien McKenna wrote: > > So the facets-lite wasn't for the pages view? I just found it by > > searching trac for "facets". > > > > > Facets-lite was only for the page _editing_ interface, not the main > sitemap view. > > What were the original goals of the project? How were you intending it > > would work? What do you now want to change on it? If you could explain > > this we might be able to help steer it in the right direction? > > > > > The original goals of the facets branch were to compartmentalize parts > of the page-editing interface so that they could be more easily and > unobtrusively modified. It operates on the principle that view > templates and partials define 'regions' that are filled with other > partials at render-time. You can define the contents of the regions via > the 'admin' object. The sample extension does a good job of showing how > to use the object. > > There are some quirks to the interface, however, and I'm not sure it's > in the right place of the API/application. > > Right now I don't have a clear answer on what I would want to change, > but my general feeling is that some things aren't quite right. I'd have > to spend some time re-reading the code to see what needs fixing. > > > I was thinking a simply way to add an action column to the Pages list > > would be an ample start to any grander plans, that would allow us to > > start making extensions behave nicely. > > > > > This is one area in which facets needed to expand. It also needed to > cover the layout and snippets interfaces as well. > > > I'd like to be able to have the ReOrder and CopyMove extensions on the > > same page, playing nicely. I can rework the extensions to suit, but > > it's tweaking the core I'm nervous about. > > > > > > If you could document what you'd like Facets to do we could try to work > > towards that goal? > > > > > > > Yes, but I prefer not creating more work for myself - when v0.6.5 or 0.7 > > rolls out with a replacement I'll have wasted time getting. > > > > > > Yes. As mentioned though if I'm going to help I'd like to at least be > > working in the same direction as the main project, so my efforts don't > > go to waste. > > > Unfortunately, facets has become kind of the > cold-fusion-Perl-6-Duke-Nukem-Forever of the Radiant project. I agree > that the functionality is sorely needed; extensions that step on each > other are a real problem. Unless it becomes stable and mature, it won't > be merged into any other branches or trunk before 0.6.5 or 0.7. > > However, if you would like to contribute, I'd say first familiarize > yourself with the codebase and especially the tests. Then, checkout > facets and create a diff between it and trunk, then merge the changes > into your facets checkout. Once you have that, go after the most > accessible part of the code that you'd like to change. Write tests, > verify your changes. Submit a patch to the Trac. Since it's an > experimental branch, if your patch looks good, I'll be sure to accept > and apply it (once I find a minute... typing this email took a while > too!). > > > Sean > _______________________________________________ > Radiant mailing list > Post: [email protected] > Search: http://radiantcms.org/mailing-list/search/ > Site: http://lists.radiantcms.org/mailman/listinfo/radiant > _______________________________________________ Radiant mailing list Post: [email protected] Search: http://radiantcms.org/mailing-list/search/ Site: http://lists.radiantcms.org/mailman/listinfo/radiant
